Re: [PATCH v6 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-18 Thread Mike Rapoport
On Tue, Jun 18, 2024 at 12:06:27PM -0400, Steven Rostedt wrote: > On Tue, 18 Jun 2024 20:55:17 +0800 > Zhengyejian wrote: > > > > + start = memblock_phys_alloc(size, align); > > > + if (!start) > > > + return -ENOMEM; > > > + > > > + reserved_mem_add(start, size, name); > > > + > > > + re

Re: [PATCH v6 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-18 Thread Steven Rostedt
On Tue, 18 Jun 2024 20:55:17 +0800 Zhengyejian wrote: > > + start = memblock_phys_alloc(size, align); > > + if (!start) > > + return -ENOMEM; > > + > > + reserved_mem_add(start, size, name); > > + > > + return 0; > > Hi, steve, should here return 1 ? Other __setup functions >

Re: [PATCH v6 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-18 Thread Zhengyejian
On 2024/6/13 23:55, Steven Rostedt wrote: From: "Steven Rostedt (Google)" In order to allow for requesting a memory region that can be used for things like pstore on multiple machines where the memory layout is not the same, add a new option to the kernel command line called "reserve_mem". The

[PATCH v6 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-13 Thread Steven Rostedt
From: "Steven Rostedt (Google)" In order to allow for requesting a memory region that can be used for things like pstore on multiple machines where the memory layout is not the same, add a new option to the kernel command line called "reserve_mem". The format is: reserve_mem=nn:align:name Wher