Re: [PATCH v6 08/17] media: rkisp1: add capture device driver

2018-04-17 Thread Tomasz Figa
Hi Jacob, On Thu, Mar 8, 2018 at 6:49 PM Jacob Chen wrote: > From: Jacob Chen > This is the capture device interface driver that provides the v4l2 > user interface. Frames can be received from ISP1. Thanks for the patch. Please find my comment inline. [snip] > +static int > +rkisp1_start_str

Re: [PATCH v6 08/17] media: rkisp1: add capture device driver

2018-03-09 Thread Hans Verkuil
On 08/03/18 10:47, Jacob Chen wrote: > From: Jacob Chen > > This is the capture device interface driver that provides the v4l2 > user interface. Frames can be received from ISP1. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Yichong Zhong > Signed-off-by: Jaco

[PATCH v6 08/17] media: rkisp1: add capture device driver

2018-03-08 Thread Jacob Chen
From: Jacob Chen This is the capture device interface driver that provides the v4l2 user interface. Frames can be received from ISP1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen Signed-off-by: Eddie Cai Signed-off-by: Jeffy