Re: [PATCH v6 08/11] mm, compaction: create compact_gap wrapper

2016-08-18 Thread Vlastimil Babka
On 08/16/2016 08:41 AM, Joonsoo Kim wrote: >> free pages for probability of compaction success, so I don't think >> it's worth complicating the compact_gap() formula. > > I agree that it's not worth complicating the compact_gap() formula but > it would be better to fix the comment? OK, Andrew can

Re: [PATCH v6 08/11] mm, compaction: create compact_gap wrapper

2016-08-15 Thread Joonsoo Kim
On Tue, Aug 16, 2016 at 08:15:36AM +0200, Vlastimil Babka wrote: > On 08/16/2016 08:15 AM, Joonsoo Kim wrote: > >On Wed, Aug 10, 2016 at 11:12:23AM +0200, Vlastimil Babka wrote: > >>--- a/include/linux/compaction.h > >>+++ b/include/linux/compaction.h > >>@@ -58,6 +58,22 @@ enum compact_result { >

Re: [PATCH v6 08/11] mm, compaction: create compact_gap wrapper

2016-08-15 Thread Vlastimil Babka
On 08/16/2016 08:15 AM, Joonsoo Kim wrote: On Wed, Aug 10, 2016 at 11:12:23AM +0200, Vlastimil Babka wrote: --- a/include/linux/compaction.h +++ b/include/linux/compaction.h @@ -58,6 +58,22 @@ enum compact_result { struct alloc_context; /* in mm/internal.h */ +/* + * Number of free order-0 pa

Re: [PATCH v6 08/11] mm, compaction: create compact_gap wrapper

2016-08-15 Thread Joonsoo Kim
On Wed, Aug 10, 2016 at 11:12:23AM +0200, Vlastimil Babka wrote: > Compaction uses a watermark gap of (2UL << order) pages at various places and > it's not immediately obvious why. Abstract it through a compact_gap() wrapper > to create a single place with a thorough explanation. > > Signed-off-by

[PATCH v6 08/11] mm, compaction: create compact_gap wrapper

2016-08-10 Thread Vlastimil Babka
Compaction uses a watermark gap of (2UL << order) pages at various places and it's not immediately obvious why. Abstract it through a compact_gap() wrapper to create a single place with a thorough explanation. Signed-off-by: Vlastimil Babka Acked-by: Michal Hocko --- include/linux/compaction.h