Re: [PATCH v6 07/19] i2c: octeon: Use i2c recovery framework

2016-04-21 Thread Wolfram Sang
> I would like to disable SMBUS_QUICK. It never worked for the read case. Fine with me. > Could we break something by disabling the quick-write case or is > the quick-write emulated by a larger write if the feature bit is not > set? No emulation. It is simply not supported then. It is actually

Re: [PATCH v6 07/19] i2c: octeon: Use i2c recovery framework

2016-04-21 Thread Jan Glauber
On Thu, Apr 21, 2016 at 03:54:50PM +0200, Wolfram Sang wrote: > > > I assumed this check was bogus and there are no valid 0-length > > messages... > > They are valid (check SMBUS_QUICK), but not every controller can handle > them correctly. Your driver has SMBUS_QUICK enabled, so this is a > cont

Re: [PATCH v6 07/19] i2c: octeon: Use i2c recovery framework

2016-04-21 Thread Wolfram Sang
> I assumed this check was bogus and there are no valid 0-length > messages... They are valid (check SMBUS_QUICK), but not every controller can handle them correctly. Your driver has SMBUS_QUICK enabled, so this is a contradiction to the check above where it rejects it. So, it looks like it need

Re: [PATCH v6 07/19] i2c: octeon: Use i2c recovery framework

2016-04-21 Thread Jan Glauber
On Wed, Apr 20, 2016 at 11:31:21PM +0200, Wolfram Sang wrote: > On Mon, Apr 11, 2016 at 05:28:38PM +0200, Jan Glauber wrote: > > Switch to the i2c bus recovery framework using generic SCL recovery. > > If this fails try to reset the hardware. The recovery is triggered > > during START on timeout of

Re: [PATCH v6 07/19] i2c: octeon: Use i2c recovery framework

2016-04-20 Thread Wolfram Sang
On Mon, Apr 11, 2016 at 05:28:38PM +0200, Jan Glauber wrote: > Switch to the i2c bus recovery framework using generic SCL recovery. > If this fails try to reset the hardware. The recovery is triggered > during START on timeout of the interrupt or failure to reach > the START / repeated-START condit

[PATCH v6 07/19] i2c: octeon: Use i2c recovery framework

2016-04-11 Thread Jan Glauber
Switch to the i2c bus recovery framework using generic SCL recovery. If this fails try to reset the hardware. The recovery is triggered during START on timeout of the interrupt or failure to reach the START / repeated-START condition. The START function is moved to xfer and while at it: - removed