Re: [alsa-devel] [PATCH v6 07/14] regmap: Add SoundWire bus support

2018-01-05 Thread Vinod Koul
On Fri, Jan 05, 2018 at 05:05:52PM +, Mark Brown wrote: > On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote: > > SoundWire bus provides sdw_read() and sdw_write() APIs for Slave > > devices to program the registers. Provide support in regmap for > > SoundWire bus. > > I can't apply th

Re: [alsa-devel] [PATCH v6 07/14] regmap: Add SoundWire bus support

2018-01-05 Thread Vinod Koul
On Fri, Jan 05, 2018 at 11:22:15AM -0600, Pierre-Louis Bossart wrote: > On 1/5/18 11:04 AM, Mark Brown wrote: > >On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote: > > > >>+ /* SoundWire register address are contiguous */ > >>+ if (config->reg_stride != 0) > >>+ return -ENOTS

Re: [PATCH v6 07/14] regmap: Add SoundWire bus support

2018-01-05 Thread Vinod Koul
On Fri, Jan 05, 2018 at 05:04:21PM +, Mark Brown wrote: > On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote: > > > + /* SoundWire register address are contiguous */ > > + if (config->reg_stride != 0) > > + return -ENOTSUPP; > > That doesn't mean the chip hasn't decided

Re: [alsa-devel] [PATCH v6 07/14] regmap: Add SoundWire bus support

2018-01-05 Thread Pierre-Louis Bossart
On 1/5/18 11:04 AM, Mark Brown wrote: On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote: + /* SoundWire register address are contiguous */ + if (config->reg_stride != 0) + return -ENOTSUPP; That doesn't mean the chip hasn't decided not to use half the addres

Re: [PATCH v6 07/14] regmap: Add SoundWire bus support

2018-01-05 Thread Mark Brown
On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote: > SoundWire bus provides sdw_read() and sdw_write() APIs for Slave > devices to program the registers. Provide support in regmap for > SoundWire bus. I can't apply this because you've changed the soundwire Kconfig in this patch :( signa

Re: [PATCH v6 07/14] regmap: Add SoundWire bus support

2018-01-05 Thread Mark Brown
On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote: > + /* SoundWire register address are contiguous */ > + if (config->reg_stride != 0) > + return -ENOTSUPP; That doesn't mean the chip hasn't decided not to use half the addresses for some reason - this isn't something

[PATCH v6 07/14] regmap: Add SoundWire bus support

2017-12-13 Thread Vinod Koul
SoundWire bus provides sdw_read() and sdw_write() APIs for Slave devices to program the registers. Provide support in regmap for SoundWire bus. Signed-off-by: Hardik T Shah Signed-off-by: Sanyog Kale Reviewed-by: Philippe Ombredanne Acked-By: Pierre-Louis Bossart Reviewed-by: Takashi Iwai Sig