RE: [PATCH v6 07/10] x86, mpx: decode MPX instruction to get bound violation information

2014-06-19 Thread Ren, Qiaowei
On 2014-06-20, H. Peter Anvin wrote: > On 06/19/2014 10:04 AM, Dave Hansen wrote: >> >> Could you please support this position with some data? I'm a bit >> skeptical that instruction decoding is going to be a >> performance-critical path. >> >> I also don't see the extra field that you talked ab

Re: [PATCH v6 07/10] x86, mpx: decode MPX instruction to get bound violation information

2014-06-19 Thread H. Peter Anvin
On 06/19/2014 10:04 AM, Dave Hansen wrote: > > Could you please support this position with some data? I'm a bit > skeptical that instruction decoding is going to be a > performance-critical path. > > I also don't see the extra field that you talked about in the previous > thread? What's the ext

Re: [PATCH v6 07/10] x86, mpx: decode MPX instruction to get bound violation information

2014-06-19 Thread Dave Hansen
On 06/18/2014 11:53 PM, Ren, Qiaowei wrote: > On 2014-06-19, Borislav Petkov wrote: >> On Thu, Jun 19, 2014 at 01:13:48AM +, Ren, Qiaowei wrote: >>> On 2014-06-18, Borislav Petkov wrote: On Wed, Jun 18, 2014 at 05:44:13PM +0800, Qiaowei Ren wrote: This whole insn decoding machine

RE: [PATCH v6 07/10] x86, mpx: decode MPX instruction to get bound violation information

2014-06-18 Thread Ren, Qiaowei
On 2014-06-19, Borislav Petkov wrote: > On Thu, Jun 19, 2014 at 01:13:48AM +, Ren, Qiaowei wrote: >> On 2014-06-18, Borislav Petkov wrote: >>> On Wed, Jun 18, 2014 at 05:44:13PM +0800, Qiaowei Ren wrote: >>> >>> This whole insn decoding machinery above looks like adapted from >>> arch/x86/lib/

Re: [PATCH v6 07/10] x86, mpx: decode MPX instruction to get bound violation information

2014-06-18 Thread Borislav Petkov
On Thu, Jun 19, 2014 at 01:13:48AM +, Ren, Qiaowei wrote: > On 2014-06-18, Borislav Petkov wrote: > > On Wed, Jun 18, 2014 at 05:44:13PM +0800, Qiaowei Ren wrote: > > > > This whole insn decoding machinery above looks like adapted from > > arch/x86/lib/insn.c. You should merge it with the gene

RE: [PATCH v6 07/10] x86, mpx: decode MPX instruction to get bound violation information

2014-06-18 Thread Ren, Qiaowei
On 2014-06-18, Borislav Petkov wrote: > On Wed, Jun 18, 2014 at 05:44:13PM +0800, Qiaowei Ren wrote: > > This whole insn decoding machinery above looks like adapted from > arch/x86/lib/insn.c. You should merge it with the generic code in > insn.c instead of homegrowing it here only for the purpose

Re: [PATCH v6 07/10] x86, mpx: decode MPX instruction to get bound violation information

2014-06-18 Thread Borislav Petkov
On Wed, Jun 18, 2014 at 05:44:13PM +0800, Qiaowei Ren wrote: > This patch sets bound violation fields of siginfo struct in #BR > exception handler by decoding the user instruction and constructing > the faulting pointer. > > Signed-off-by: Qiaowei Ren > --- > arch/x86/include/asm/mpx.h | 23 ++

[PATCH v6 07/10] x86, mpx: decode MPX instruction to get bound violation information

2014-06-18 Thread Qiaowei Ren
This patch sets bound violation fields of siginfo struct in #BR exception handler by decoding the user instruction and constructing the faulting pointer. Signed-off-by: Qiaowei Ren --- arch/x86/include/asm/mpx.h | 23 arch/x86/kernel/mpx.c | 294 +