Re: [PATCH v6 06/18] virt: acrn: Introduce VM management interfaces

2021-01-05 Thread Shuo A Liu
On Tue 5.Jan'21 at 15:03:06 +0100, Greg Kroah-Hartman wrote: On Tue, Dec 15, 2020 at 06:02:51PM +0800, Shuo A Liu wrote: On Tue 15.Dec'20 at 11:00:57 +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 15, 2020 at 05:52:59PM +0800, Shuo A Liu wrote: > > On Wed 2.Dec'20 at 10:14:29 +0800, Shuo A Liu

Re: [PATCH v6 06/18] virt: acrn: Introduce VM management interfaces

2021-01-05 Thread Greg Kroah-Hartman
On Tue, Dec 15, 2020 at 06:02:51PM +0800, Shuo A Liu wrote: > On Tue 15.Dec'20 at 11:00:57 +0100, Greg Kroah-Hartman wrote: > > On Tue, Dec 15, 2020 at 05:52:59PM +0800, Shuo A Liu wrote: > > > On Wed 2.Dec'20 at 10:14:29 +0800, Shuo A Liu wrote: > > > > On Tue 1.Dec'20 at 11:09:47 +0100, Greg Kr

Re: [PATCH v6 06/18] virt: acrn: Introduce VM management interfaces

2020-12-15 Thread Shuo A Liu
On Tue 15.Dec'20 at 11:00:57 +0100, Greg Kroah-Hartman wrote: On Tue, Dec 15, 2020 at 05:52:59PM +0800, Shuo A Liu wrote: On Wed 2.Dec'20 at 10:14:29 +0800, Shuo A Liu wrote: > On Tue 1.Dec'20 at 11:09:47 +0100, Greg Kroah-Hartman wrote: > > On Tue, Dec 01, 2020 at 05:38:41PM +0800, shuo.a

Re: [PATCH v6 06/18] virt: acrn: Introduce VM management interfaces

2020-12-15 Thread Greg Kroah-Hartman
On Tue, Dec 15, 2020 at 05:52:59PM +0800, Shuo A Liu wrote: > On Wed 2.Dec'20 at 10:14:29 +0800, Shuo A Liu wrote: > > On Tue 1.Dec'20 at 11:09:47 +0100, Greg Kroah-Hartman wrote: > > > On Tue, Dec 01, 2020 at 05:38:41PM +0800, shuo.a@intel.com wrote: > > > > + vm_param->reserve

Re: [PATCH v6 06/18] virt: acrn: Introduce VM management interfaces

2020-12-15 Thread Shuo A Liu
On Wed 2.Dec'20 at 10:14:29 +0800, Shuo A Liu wrote: On Tue 1.Dec'20 at 11:09:47 +0100, Greg Kroah-Hartman wrote: On Tue, Dec 01, 2020 at 05:38:41PM +0800, shuo.a@intel.com wrote: + vm_param->reserved0 = 0; + vm_param->reserved1 = 0; NO! This means that user

Re: [PATCH v6 06/18] virt: acrn: Introduce VM management interfaces

2020-12-01 Thread Shuo A Liu
On Tue 1.Dec'20 at 11:09:47 +0100, Greg Kroah-Hartman wrote: On Tue, Dec 01, 2020 at 05:38:41PM +0800, shuo.a@intel.com wrote: + vm_param->reserved0 = 0; + vm_param->reserved1 = 0; NO! This means that userspace can put whatever crud they want in those fields,

Re: [PATCH v6 06/18] virt: acrn: Introduce VM management interfaces

2020-12-01 Thread Greg Kroah-Hartman
On Tue, Dec 01, 2020 at 05:38:41PM +0800, shuo.a@intel.com wrote: > + vm_param->reserved0 = 0; > + vm_param->reserved1 = 0; NO! This means that userspace can put whatever crud they want in those fields, and you will happily zero it out. Then, when those reserved field

[PATCH v6 06/18] virt: acrn: Introduce VM management interfaces

2020-12-01 Thread shuo . a . liu
From: Shuo Liu The VM management interfaces expose several VM operations to ACRN userspace via ioctls. For example, creating VM, starting VM, destroying VM and so on. The ACRN Hypervisor needs to exchange data with the ACRN userspace during the VM operations. HSM provides VM operation ioctls to