Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor list

2017-06-12 Thread Christoph Hellwig
On Mon, Jun 12, 2017 at 03:33:11AM +, Chaitanya Kulkarni wrote: > Right now I'm keeping the framework under "${KDIR}/tools/testing/selftests/", > please let me know if that is not a desirable directory. Heh, Johannes and I just had a discussion on the test framework locations last weekend ove

Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor list

2017-06-08 Thread Christoph Hellwig
On Thu, Jun 08, 2017 at 09:55:37AM +0200, Johannes Thumshirn wrote: > Btw, is the NVMf sleftests still avtively developed? If yes I have a > testcase for this series (not sure this qualifies for blktests) As-is it's pretty dead, but Chaitanya has been looking into resurrecting it in a modern form.

Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor list

2017-06-08 Thread Johannes Thumshirn
On 06/08/2017 09:52 AM, Christoph Hellwig wrote: > On Thu, Jun 08, 2017 at 09:49:35AM +0200, Johannes Thumshirn wrote: >> On 06/08/2017 09:44 AM, Christoph Hellwig wrote: + if (sg_zeroout_area(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE, off) >>> >>> Shouldn;t the third argument be NVME_IDE

Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor list

2017-06-08 Thread Christoph Hellwig
On Thu, Jun 08, 2017 at 09:49:35AM +0200, Johannes Thumshirn wrote: > On 06/08/2017 09:44 AM, Christoph Hellwig wrote: > >> + if (sg_zeroout_area(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE, off) > > > > Shouldn;t the third argument be NVME_IDENTIFY_DATA_SIZE - off in theory? > > It's probably

Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor list

2017-06-08 Thread Johannes Thumshirn
On 06/08/2017 09:44 AM, Christoph Hellwig wrote: >> +if (sg_zeroout_area(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE, off) > > Shouldn;t the third argument be NVME_IDENTIFY_DATA_SIZE - off in theory? > It's probably fine as is as the S/G helpers deal with overflows > gracefully, but still..

Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor list

2017-06-08 Thread Christoph Hellwig
On Wed, Jun 07, 2017 at 11:45:32AM +0200, Johannes Thumshirn wrote: > A NVMe Identify NS command with a CNS value of '3' is expecting a list > of Namespace Identification Descriptor structures to be returned to > the host for the namespace requested in the namespace identify > command. > > This Na

Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor list

2017-06-07 Thread Sagi Grimberg
Last one :) Reviewed-by: Sagi Grimberg Thanks Johannes

[PATCH v6 05/10] nvmet: implement namespace identify descriptor list

2017-06-07 Thread Johannes Thumshirn
A NVMe Identify NS command with a CNS value of '3' is expecting a list of Namespace Identification Descriptor structures to be returned to the host for the namespace requested in the namespace identify command. This Namespace Identification Descriptor structure consists of the type of the namespac