Re: [PATCH v6 04/19] spi: spi-mem: allow specifying a command's extension

2020-05-22 Thread Pratyush Yadav
Hi Boris, On 21/05/20 08:22PM, Boris Brezillon wrote: > On Wed, 20 May 2020 22:00:38 +0530 > Pratyush Yadav wrote: > > As mentioned in one of my previous review, you should patch the mxic > driver before extending the opcode field: > > --->8--- > diff --git a/drivers/spi/spi-mxic.c b/drivers/sp

Re: [PATCH v6 04/19] spi: spi-mem: allow specifying a command's extension

2020-05-21 Thread Boris Brezillon
On Fri, 22 May 2020 01:33:15 +0530 Pratyush Yadav wrote: > On 22/05/20 01:11AM, Pratyush Yadav wrote: > > On 21/05/20 08:22PM, Boris Brezillon wrote: > > > On Wed, 20 May 2020 22:00:38 +0530 > > > Pratyush Yadav wrote: > > > > > > > In xSPI mode, flashes expect 2-byte opcodes. The second by

Re: [PATCH v6 04/19] spi: spi-mem: allow specifying a command's extension

2020-05-21 Thread Pratyush Yadav
On 22/05/20 01:11AM, Pratyush Yadav wrote: > On 21/05/20 08:22PM, Boris Brezillon wrote: > > On Wed, 20 May 2020 22:00:38 +0530 > > Pratyush Yadav wrote: > > > > > In xSPI mode, flashes expect 2-byte opcodes. The second byte is called > > > the "command extension". There can be 3 types of extensi

Re: [PATCH v6 04/19] spi: spi-mem: allow specifying a command's extension

2020-05-21 Thread Pratyush Yadav
On 21/05/20 08:22PM, Boris Brezillon wrote: > On Wed, 20 May 2020 22:00:38 +0530 > Pratyush Yadav wrote: > > > In xSPI mode, flashes expect 2-byte opcodes. The second byte is called > > the "command extension". There can be 3 types of extensions in xSPI: > > repeat, invert, and hex. When the exte

Re: [PATCH v6 04/19] spi: spi-mem: allow specifying a command's extension

2020-05-21 Thread Boris Brezillon
On Wed, 20 May 2020 22:00:38 +0530 Pratyush Yadav wrote: > In xSPI mode, flashes expect 2-byte opcodes. The second byte is called > the "command extension". There can be 3 types of extensions in xSPI: > repeat, invert, and hex. When the extension type is "repeat", the same > opcode is sent twice.

[PATCH v6 04/19] spi: spi-mem: allow specifying a command's extension

2020-05-20 Thread Pratyush Yadav
In xSPI mode, flashes expect 2-byte opcodes. The second byte is called the "command extension". There can be 3 types of extensions in xSPI: repeat, invert, and hex. When the extension type is "repeat", the same opcode is sent twice. When it is "invert", the second byte is the inverse of the opcode.