Re: [PATCH v6 02/46] virtio: use u32, not bitmap for features

2014-11-29 Thread Michael S. Tsirkin
On Fri, Nov 28, 2014 at 01:44:57PM +0100, Cornelia Huck wrote: > On Thu, 27 Nov 2014 22:07:41 +0200 > "Michael S. Tsirkin" wrote: > > > It seemed like a good idea to use bitmap for features > > in struct virtio_device, but it's actually a pain, > > and seems to become even more painful when we ge

Re: [PATCH v6 02/46] virtio: use u32, not bitmap for features

2014-11-28 Thread Cornelia Huck
On Thu, 27 Nov 2014 22:07:41 +0200 "Michael S. Tsirkin" wrote: > It seemed like a good idea to use bitmap for features > in struct virtio_device, but it's actually a pain, > and seems to become even more painful when we get more > than 32 feature bits. Just change it to a u32 for now. > > Based

[PATCH v6 02/46] virtio: use u32, not bitmap for features

2014-11-27 Thread Michael S. Tsirkin
It seemed like a good idea to use bitmap for features in struct virtio_device, but it's actually a pain, and seems to become even more painful when we get more than 32 feature bits. Just change it to a u32 for now. Based on patch by Rusty. Suggested-by: David Hildenbrand Signed-off-by: Rusty Ru