Re: [PATCH v6 02/28] x86/asm/suspend: drop ENTRY from local data

2018-05-19 Thread Pavel Machek
On Fri 2018-05-18 11:16:55, Jiri Slaby wrote: > ENTRY was intended for functions and shall be paired with ENDPROC. > ENTRY also aligns symbols which creates unnecessary holes here between > data. > > So drop ENTRY from saved_eip in wakeup_32 and many saved_* in wakeup_64, > as these symbols are lo

Re: [PATCH v6 02/28] x86/asm/suspend: drop ENTRY from local data

2018-05-18 Thread Rafael J. Wysocki
On Fri, May 18, 2018 at 11:16 AM, Jiri Slaby wrote: > ENTRY was intended for functions and shall be paired with ENDPROC. > ENTRY also aligns symbols which creates unnecessary holes here between > data. > > So drop ENTRY from saved_eip in wakeup_32 and many saved_* in wakeup_64, > as these symbols

[PATCH v6 02/28] x86/asm/suspend: drop ENTRY from local data

2018-05-18 Thread Jiri Slaby
ENTRY was intended for functions and shall be paired with ENDPROC. ENTRY also aligns symbols which creates unnecessary holes here between data. So drop ENTRY from saved_eip in wakeup_32 and many saved_* in wakeup_64, as these symbols are local only. We could use SYM_DATA_LOCAL for these symbols,