Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-20 Thread Peter Chen
On Wed, Apr 20, 2016 at 11:15:30AM +0300, Roger Quadros wrote: > On 19/04/16 04:56, Peter Chen wrote: > > On Mon, Apr 18, 2016 at 10:11:29AM -0400, Alan Stern wrote: > >> On Mon, 18 Apr 2016, Peter Chen wrote: > >> > >>> On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: > On 06/04

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-20 Thread Roger Quadros
On 19/04/16 04:56, Peter Chen wrote: > On Mon, Apr 18, 2016 at 10:11:29AM -0400, Alan Stern wrote: >> On Mon, 18 Apr 2016, Peter Chen wrote: >> >>> On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: On 06/04/16 09:09, Felipe Balbi wrote: > > Hi, > > Roger Quadros w

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-18 Thread Peter Chen
On Mon, Apr 18, 2016 at 10:11:29AM -0400, Alan Stern wrote: > On Mon, 18 Apr 2016, Peter Chen wrote: > > > On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: > > > On 06/04/16 09:09, Felipe Balbi wrote: > > > > > > > > Hi, > > > > > > > > Roger Quadros writes: > > > >> diff --git a/

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-18 Thread Alan Stern
On Mon, 18 Apr 2016, Peter Chen wrote: > On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: > > On 06/04/16 09:09, Felipe Balbi wrote: > > > > > > Hi, > > > > > > Roger Quadros writes: > > >> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > > >> index 2ca2cef..6b1930d

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-17 Thread Peter Chen
On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: > On 06/04/16 09:09, Felipe Balbi wrote: > > > > Hi, > > > > Roger Quadros writes: > >> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > >> index 2ca2cef..6b1930d 100644 > >> --- a/drivers/usb/core/hcd.c > >> +++ b/driv

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-08 Thread Peter Chen
On Fri, Apr 08, 2016 at 10:16:30AM +0300, Roger Quadros wrote: > On 08/04/16 04:01, Peter Chen wrote: > > On Thu, Apr 07, 2016 at 01:40:21PM +0300, Roger Quadros wrote: > >> On 07/04/16 12:42, Peter Chen wrote: > >>> On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: > On 06/04/16

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-08 Thread Roger Quadros
On 08/04/16 04:01, Peter Chen wrote: > On Thu, Apr 07, 2016 at 01:40:21PM +0300, Roger Quadros wrote: >> On 07/04/16 12:42, Peter Chen wrote: >>> On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: On 06/04/16 09:09, Felipe Balbi wrote: > > Hi, > > Roger Quadros wri

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-07 Thread Peter Chen
On Thu, Apr 07, 2016 at 01:40:21PM +0300, Roger Quadros wrote: > On 07/04/16 12:42, Peter Chen wrote: > > On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: > >> On 06/04/16 09:09, Felipe Balbi wrote: > >>> > >>> Hi, > >>> > >>> Roger Quadros writes: > diff --git a/drivers/usb/cor

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-07 Thread Roger Quadros
On 07/04/16 12:42, Peter Chen wrote: > On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: >> On 06/04/16 09:09, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros writes: diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 2ca2cef..6b1930d 100644 --- a/

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-07 Thread Peter Chen
On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote: > On 06/04/16 09:09, Felipe Balbi wrote: > > > > Hi, > > > > Roger Quadros writes: > >> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > >> index 2ca2cef..6b1930d 100644 > >> --- a/drivers/usb/core/hcd.c > >> +++ b/driv

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-05 Thread Roger Quadros
On 06/04/16 09:09, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c >> index 2ca2cef..6b1930d 100644 >> --- a/drivers/usb/core/hcd.c >> +++ b/drivers/usb/core/hcd.c >> @@ -2706,6 +2706,7 @@ int usb_add_hcd(struct usb_hcd *hcd,

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-05 Thread Felipe Balbi
Hi, Roger Quadros writes: > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > index 2ca2cef..6b1930d 100644 > --- a/drivers/usb/core/hcd.c > +++ b/drivers/usb/core/hcd.c > @@ -2706,6 +2706,7 @@ int usb_add_hcd(struct usb_hcd *hcd, > int retval; > struct usb_device *rhdev

[PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

2016-04-05 Thread Roger Quadros
When using the OTG/drd library we can call hcd_add/remove consecutively without calling hcd_alloc in between so flags can be stale. If the HC dies due to whatever reason then without this patch we get the below error on next hcd_add. [ 91.494257] xhci-hcd xhci-hcd.0.auto: HC died; cleaning up [