Re: [PATCH v6] mfd: syscon: Add hardware spinlock support

2017-12-19 Thread Baolin Wang
On 19 December 2017 at 17:21, Mark Brown wrote: > On Tue, Dec 19, 2017 at 02:55:47PM +0800, Baolin Wang wrote: > >> Um, why regmap doesn't accept a zero lock-id, that because regmap will >> reguest hwlock depending on the 'regmap_config->hwlock_id' is not >> zero, if regmap regard a zero lock-id a

Re: [PATCH v6] mfd: syscon: Add hardware spinlock support

2017-12-19 Thread Mark Brown
On Tue, Dec 19, 2017 at 02:55:47PM +0800, Baolin Wang wrote: > Um, why regmap doesn't accept a zero lock-id, that because regmap will > reguest hwlock depending on the 'regmap_config->hwlock_id' is not > zero, if regmap regard a zero lock-id as valid which will affect other > 'struct regmap_config

Re: [PATCH v6] mfd: syscon: Add hardware spinlock support

2017-12-18 Thread Baolin Wang
On 18 December 2017 at 20:44, Arnd Bergmann wrote: > On Mon, Dec 18, 2017 at 7:54 AM, Baolin Wang wrote: >> On 15 December 2017 at 21:13, Arnd Bergmann wrote: >>> On Fri, Dec 15, 2017 at 11:42 AM, Lee Jones wrote: >>> > @@ -87,6 +88,30 @@ static struct syscon *of_syscon_register(struct >>>

Re: [PATCH v6] mfd: syscon: Add hardware spinlock support

2017-12-18 Thread Arnd Bergmann
On Mon, Dec 18, 2017 at 7:54 AM, Baolin Wang wrote: > On 15 December 2017 at 21:13, Arnd Bergmann wrote: >> On Fri, Dec 15, 2017 at 11:42 AM, Lee Jones wrote: >> @@ -87,6 +88,30 @@ static struct syscon *of_syscon_register(struct device_node *np) if (ret)

Re: [PATCH v6] mfd: syscon: Add hardware spinlock support

2017-12-17 Thread Baolin Wang
On 15 December 2017 at 21:13, Arnd Bergmann wrote: > On Fri, Dec 15, 2017 at 11:42 AM, Lee Jones wrote: > >>> @@ -87,6 +88,30 @@ static struct syscon *of_syscon_register(struct >>> device_node *np) >>> if (ret) >>> reg_io_width = 4; >>> >>> + ret = of_hwspin_lock_get_id(n

Re: [PATCH v6] mfd: syscon: Add hardware spinlock support

2017-12-15 Thread Arnd Bergmann
On Fri, Dec 15, 2017 at 11:42 AM, Lee Jones wrote: >> @@ -87,6 +88,30 @@ static struct syscon *of_syscon_register(struct >> device_node *np) >> if (ret) >> reg_io_width = 4; >> >> + ret = of_hwspin_lock_get_id(np, 0); >> + if (ret > 0) { >> + syscon_config

Re: [PATCH v6] mfd: syscon: Add hardware spinlock support

2017-12-15 Thread Lee Jones
Arnd, > Some system control registers need hardware spinlock to synchronize > between the multiple subsystems, so we should add hardware spinlock > support for syscon. > > Signed-off-by: Baolin Wang > Acked-by: Rob Herring > --- > Changes since v5: > - Fix the case that hwspinlock is not enabl

[PATCH v6] mfd: syscon: Add hardware spinlock support

2017-11-30 Thread Baolin Wang
Some system control registers need hardware spinlock to synchronize between the multiple subsystems, so we should add hardware spinlock support for syscon. Signed-off-by: Baolin Wang Acked-by: Rob Herring --- Changes since v5: - Fix the case that hwspinlock is not enabled. Changes since v4: -