Re: [PATCH v6] USB hub_probe: rework ugly goto-into-compound-statement

2016-11-21 Thread Greg Kroah-Hartman
On Sat, Nov 19, 2016 at 09:55:45AM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > Changes in v6: more pedantic conversion from `in

[PATCH v6] USB hub_probe: rework ugly goto-into-compound-statement

2016-11-18 Thread Eugene Korenevsky
Rework smelling code (goto inside compound statement). Perhaps this is legacy. Anyway such code is not appropriate for Linux kernel. Signed-off-by: Eugene Korenevsky --- Changes in v6: more pedantic conversion from `int` to `bool`; fix comment Changes in v5: make `bool` a return type of `hub_chec