Re: [PATCH v6] Cypress PS/2 Trackpad driver

On Mon, Dec 10, 2012 at 06:13:59PM +0100, Henrik Rydberg wrote: > > > > +config MOUSE_PS2_CYPRESS > > > > + bool "Cypress PS/2 mouse protocol extension" if EXPERT > > > > > > Why EXPERT here? > > > > > > > + default y > > > > > > Should it really be default y here? > > > > > > This

Re: [PATCH v6] Cypress PS/2 Trackpad driver

> > > +config MOUSE_PS2_CYPRESS > > > + bool "Cypress PS/2 mouse protocol extension" if EXPERT > > > > Why EXPERT here? > > > > > + default y > > > > Should it really be default y here? > > > This config entry (with phrases "if EXPERT" and "default y") was simply > cloned from simi

RE: [PATCH v6] Cypress PS/2 Trackpad driver

Hi Kamal, I think in default branch in cypress_get_finger_count() function return 0 is not suitable, We should return a value bigger than 5 to indicate invalid package to avoid unable to distinguish really 0 contact_cnt packages. 0 contact_cnt packages may still have valid left/right mechanical

Re: [PATCH v6] Cypress PS/2 Trackpad driver

Hi Henrik- On Sat, 2012-12-08 at 13:54 +0100, Henrik Rydberg wrote: > [...] > > --- a/drivers/input/mouse/Kconfig > > +++ b/drivers/input/mouse/Kconfig > > @@ -68,6 +68,16 @@ config MOUSE_PS2_SYNAPTICS > > > > If unsure, say Y. > > > > +config MOUSE_PS2_CYPRESS > > + bool "Cypress

Re: [PATCH v6] Cypress PS/2 Trackpad driver

Hi Kamal, > This driver, submitted on behalf of Cypress Semiconductor Corporation and > additional contributors, provides support for the Cypress PS/2 Trackpad. > > Note that the patch "increase struct ps2dev cmdbuf[] to 8 bytes" [5] is a > PREREQUISITE for this patch. > > This [PATCH v6] versio

[PATCH v6] Cypress PS/2 Trackpad driver

This driver, submitted on behalf of Cypress Semiconductor Corporation and additional contributors, provides support for the Cypress PS/2 Trackpad. Note that the patch "increase struct ps2dev cmdbuf[] to 8 bytes" [5] is a PREREQUISITE for this patch. This [PATCH v6] version differs from my previou