Re: [PATCH v6] ANDROID: binder: change down_write to down_read

2018-05-16 Thread Joel Fernandes
On Tue, May 15, 2018 at 03:27:32PM +0900, Minchan Kim wrote: > Hi Joel, > > Sorry for the late response. I was off. > > On Wed, May 09, 2018 at 04:19:41PM -0700, Joel Fernandes wrote: > > On Wed, May 09, 2018 at 03:40:23PM +0900, Minchan Kim wrote: > > > On Tue, May 08, 2018 at 04:08:13PM -0700,

Re: [PATCH v6] ANDROID: binder: change down_write to down_read

2018-05-15 Thread Minchan Kim
On Tue, May 15, 2018 at 09:46:01AM +0200, Martijn Coenen wrote: < snip > > >> About the unmap at runtime part, your commit message was a bit confusing. > >> You > >> said "every binder buffers should be mapped in advance by binder_mmap." > >> but I > >> think the new binder shrinker mechanism d

Re: [PATCH v6] ANDROID: binder: change down_write to down_read

2018-05-15 Thread Martijn Coenen
On Tue, May 15, 2018 at 8:27 AM, Minchan Kim wrote: > Hi Joel, > > Sorry for the late response. I was off. > > On Wed, May 09, 2018 at 04:19:41PM -0700, Joel Fernandes wrote: >> On Wed, May 09, 2018 at 03:40:23PM +0900, Minchan Kim wrote: >> > On Tue, May 08, 2018 at 04:08:13PM -0700, Joel Fernand

Re: [PATCH v6] ANDROID: binder: change down_write to down_read

2018-05-14 Thread Minchan Kim
Hi Joel, Sorry for the late response. I was off. On Wed, May 09, 2018 at 04:19:41PM -0700, Joel Fernandes wrote: > On Wed, May 09, 2018 at 03:40:23PM +0900, Minchan Kim wrote: > > On Tue, May 08, 2018 at 04:08:13PM -0700, Joel Fernandes wrote: > > > On Tue, May 08, 2018 at 07:51:01PM +0900, Minch

Re: [PATCH v6] ANDROID: binder: change down_write to down_read

2018-05-09 Thread Joel Fernandes
On Wed, May 09, 2018 at 03:40:23PM +0900, Minchan Kim wrote: > On Tue, May 08, 2018 at 04:08:13PM -0700, Joel Fernandes wrote: > > On Tue, May 08, 2018 at 07:51:01PM +0900, Minchan Kim wrote: > > > On Mon, May 07, 2018 at 10:28:29AM -0700, Joel Fernandes wrote: > > > > On Mon, May 07, 2018 at 11:15

Re: [PATCH v6] ANDROID: binder: change down_write to down_read

2018-05-08 Thread Minchan Kim
On Tue, May 08, 2018 at 04:08:13PM -0700, Joel Fernandes wrote: > On Tue, May 08, 2018 at 07:51:01PM +0900, Minchan Kim wrote: > > On Mon, May 07, 2018 at 10:28:29AM -0700, Joel Fernandes wrote: > > > On Mon, May 07, 2018 at 11:15:37PM +0900, Minchan Kim wrote: > > > > binder_update_page_range need

Re: [PATCH v6] ANDROID: binder: change down_write to down_read

2018-05-08 Thread Joel Fernandes
On Tue, May 08, 2018 at 07:51:01PM +0900, Minchan Kim wrote: > On Mon, May 07, 2018 at 10:28:29AM -0700, Joel Fernandes wrote: > > On Mon, May 07, 2018 at 11:15:37PM +0900, Minchan Kim wrote: > > > binder_update_page_range needs down_write of mmap_sem because > > > vm_insert_page need to change vma

Re: [PATCH v6] ANDROID: binder: change down_write to down_read

2018-05-08 Thread Minchan Kim
On Mon, May 07, 2018 at 10:28:29AM -0700, Joel Fernandes wrote: > On Mon, May 07, 2018 at 11:15:37PM +0900, Minchan Kim wrote: > > binder_update_page_range needs down_write of mmap_sem because > > vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless > > it is set. However, when I profi

Re: [PATCH v6] ANDROID: binder: change down_write to down_read

2018-05-07 Thread Joel Fernandes
On Mon, May 07, 2018 at 11:15:37PM +0900, Minchan Kim wrote: > binder_update_page_range needs down_write of mmap_sem because > vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless > it is set. However, when I profile binder working, it seems > every binder buffers should be mapped in a

[PATCH v6] ANDROID: binder: change down_write to down_read

2018-05-07 Thread Minchan Kim
binder_update_page_range needs down_write of mmap_sem because vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless it is set. However, when I profile binder working, it seems every binder buffers should be mapped in advance by binder_mmap. It means we could set VM_MIXEDMAP in binder_mm