Re: [PATCH v5 6/8] pinctrl: cygnus: add gpio/pinconf driver

2015-03-09 Thread Paul Bolle
Linus Walleij schreef op ma 09-03-2015 om 17:41 [+0100]: > As pointed out in another mail on similar subject, I think these macros > are a kind of obsolete documentation and if they should be dropped we > need to go over an entire subsystem at a time and remove all boolean users > in a big patch.

Re: [PATCH v5 6/8] pinctrl: cygnus: add gpio/pinconf driver

2015-03-09 Thread Linus Walleij
On Thu, Mar 5, 2015 at 6:13 PM, Ray Jui wrote: >> (I knew the other three MODULE_* macros are handled in slightly more >> complicated way, but the effect is basically that they are preprocessed >> away.) >> >> Paul Bolle > > Even these module macros will be pre-processed away when the driver is >

Re: [PATCH v5 6/8] pinctrl: cygnus: add gpio/pinconf driver

2015-03-05 Thread Ray Jui
Hi Paul, On 3/5/2015 12:36 AM, Paul Bolle wrote: > On Thu, 2015-03-05 at 09:11 +0100, Paul Bolle wrote: >> On Wed, 2015-03-04 at 16:35 -0800, Ray Jui wrote: >>> +MODULE_AUTHOR("Ray Jui "); >>> +MODULE_DESCRIPTION("Broadcom Cygnus GPIO Driver"); >>> +MODULE_LICENSE("GPL v2"); >> >> These three macr

Re: [PATCH v5 6/8] pinctrl: cygnus: add gpio/pinconf driver

2015-03-05 Thread Paul Bolle
On Thu, 2015-03-05 at 09:11 +0100, Paul Bolle wrote: > On Wed, 2015-03-04 at 16:35 -0800, Ray Jui wrote: > > +MODULE_AUTHOR("Ray Jui "); > > +MODULE_DESCRIPTION("Broadcom Cygnus GPIO Driver"); > > +MODULE_LICENSE("GPL v2"); > > These three macros will be preprocessed away. (There's also > MODULE_D

Re: [PATCH v5 6/8] pinctrl: cygnus: add gpio/pinconf driver

2015-03-05 Thread Paul Bolle
On Wed, 2015-03-04 at 16:35 -0800, Ray Jui wrote: > --- a/drivers/pinctrl/bcm/Kconfig > +++ b/drivers/pinctrl/bcm/Kconfig > @@ -20,6 +20,28 @@ config PINCTRL_BCM2835 > select PINMUX > select PINCONF > > +config PINCTRL_CYGNUS_GPIO > + bool "Broadcom Cygnus GPIO (with PINCONF) driv

[PATCH v5 6/8] pinctrl: cygnus: add gpio/pinconf driver

2015-03-04 Thread Ray Jui
This adds the initial support of the Broadcom Cygnus GPIO/PINCONF driver that supports all 3 GPIO controllers on Cygnus including the ASIU GPIO controller, the chipCommonG GPIO controller, and the always-on GPIO controller. Basic PINCONF configurations such as bias pull up/down, and drive strength