Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-13 Thread dbasehore .
On Wed, Jul 12, 2017 at 10:11 PM, Thomas Gleixner wrote: > On Wed, 12 Jul 2017, dbasehore . wrote: >> On Wed, Jul 12, 2017 at 3:16 PM, Thomas Gleixner wrote: >> > There are more issues with this: If there is a hrtimer scheduled on that >> > last CPU which enters the idle freeze state and that tim

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-12 Thread Thomas Gleixner
On Wed, 12 Jul 2017, dbasehore . wrote: > On Wed, Jul 12, 2017 at 3:16 PM, Thomas Gleixner wrote: > > There are more issues with this: If there is a hrtimer scheduled on that > > last CPU which enters the idle freeze state and that timer is 10 minutes > > away, then the check timer can't be progra

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-12 Thread dbasehore .
On Wed, Jul 12, 2017 at 3:16 PM, Thomas Gleixner wrote: > On Fri, 7 Jul 2017, Derek Basehore wrote: >> This adds validation of S0ix entry and enables it on Skylake. Using >> the new tick_set_freeze_event function, we program the CPU to wake up >> X seconds after entering freeze. After X seconds, i

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-12 Thread dbasehore .
On Wed, Jul 12, 2017 at 3:16 PM, Thomas Gleixner wrote: > On Fri, 7 Jul 2017, Derek Basehore wrote: >> This adds validation of S0ix entry and enables it on Skylake. Using >> the new tick_set_freeze_event function, we program the CPU to wake up >> X seconds after entering freeze. After X seconds, i

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-12 Thread Thomas Gleixner
On Fri, 7 Jul 2017, Derek Basehore wrote: > This adds validation of S0ix entry and enables it on Skylake. Using > the new tick_set_freeze_event function, we program the CPU to wake up > X seconds after entering freeze. After X seconds, it will wake the CPU > to check the S0ix residency counters and

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-11 Thread Len Brown
I acknowledge the specific need for this check to assure a great user-experience on specific hardware. I also concur the motivation to make mechanisms general and generic so they can be re-used. However, it isn't clear to me that this check would be used outside of some very specific scenarios, a

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-11 Thread Rafael J. Wysocki
On Monday, July 10, 2017 03:24:14 PM dbasehore . wrote: > On Mon, Jul 10, 2017 at 3:09 PM, Rafael J. Wysocki wrote: > > On Monday, July 10, 2017 02:57:48 PM dbasehore . wrote: > >> On Mon, Jul 10, 2017 at 6:33 AM, Rafael J. Wysocki > >> wrote: > >> > On Friday, July 07, 2017 05:03:03 PM Derek Ba

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-10 Thread dbasehore .
On Mon, Jul 10, 2017 at 3:09 PM, Rafael J. Wysocki wrote: > On Monday, July 10, 2017 02:57:48 PM dbasehore . wrote: >> On Mon, Jul 10, 2017 at 6:33 AM, Rafael J. Wysocki >> wrote: >> > On Friday, July 07, 2017 05:03:03 PM Derek Basehore wrote: >> >> This adds validation of S0ix entry and enables

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-10 Thread Rafael J. Wysocki
On Monday, July 10, 2017 02:57:48 PM dbasehore . wrote: > On Mon, Jul 10, 2017 at 6:33 AM, Rafael J. Wysocki wrote: > > On Friday, July 07, 2017 05:03:03 PM Derek Basehore wrote: > >> This adds validation of S0ix entry and enables it on Skylake. Using > >> the new tick_set_freeze_event function, w

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-10 Thread dbasehore .
On Mon, Jul 10, 2017 at 6:33 AM, Rafael J. Wysocki wrote: > On Friday, July 07, 2017 05:03:03 PM Derek Basehore wrote: >> This adds validation of S0ix entry and enables it on Skylake. Using >> the new tick_set_freeze_event function, we program the CPU to wake up >> X seconds after entering freeze.

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-10 Thread Rafael J. Wysocki
On Friday, July 07, 2017 05:03:03 PM Derek Basehore wrote: > This adds validation of S0ix entry and enables it on Skylake. Using > the new tick_set_freeze_event function, we program the CPU to wake up > X seconds after entering freeze. After X seconds, it will wake the CPU > to check the S0ix resid

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-09 Thread kbuild test robot
Hi Derek, [auto build test ERROR on pm/linux-next] [also build test ERROR on next-20170707] [cannot apply to v4.12] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Derek-Basehore/x86-stub-out-pmc

[PATCH v5 5/5] intel_idle: Add S0ix validation

2017-07-07 Thread Derek Basehore
This adds validation of S0ix entry and enables it on Skylake. Using the new tick_set_freeze_event function, we program the CPU to wake up X seconds after entering freeze. After X seconds, it will wake the CPU to check the S0ix residency counters and make sure we entered the lowest power state for s