Ray Jui schreef op ma 09-03-2015 om 12:40 [-0700]:
> I don't see this as an "issue" to be quite honest.
(Off topic: is issue a, well, strong word? To my (non-English) mind it's
rather neutral, carrying by itself less urgency than, say, problem. If
I'm wrong I might have confused quite a few people
On 3/9/2015 12:30 PM, Paul Bolle wrote:
> Ray Jui schreef op ma 09-03-2015 om 12:00 [-0700]:
>> I think it depends on how you see it. Based on this logic, then one can
>> also argue comments in the code will be pre-processed away and are not
>> needed. They at least serve the same documentation p
Ray Jui schreef op ma 09-03-2015 om 12:00 [-0700]:
> I think it depends on how you see it. Based on this logic, then one can
> also argue comments in the code will be pre-processed away and are not
> needed. They at least serve the same documentation purpose in a way.
So why not make them comments
On 3/9/2015 11:40 AM, Paul Bolle wrote:
> Linus Walleij schreef op ma 09-03-2015 om 17:28 [+0100]:
>> I think you're right. Or I fear you're right.
>>
>> But this problem is present in so many drivers that a generic
>> fixup needs to be done with a script and across an entire subsystem
>> at once
Linus Walleij schreef op ma 09-03-2015 om 17:28 [+0100]:
> I think you're right. Or I fear you're right.
>
> But this problem is present in so many drivers that a generic
> fixup needs to be done with a script and across an entire subsystem
> at once,
Why don't we start with checking for similar
On Thu, Mar 5, 2015 at 9:03 AM, Paul Bolle wrote:
>>[...]
>> +MODULE_AUTHOR("Ray Jui ");
>> +MODULE_DESCRIPTION("Broadcom Cygnus IOMUX driver");
>> +MODULE_LICENSE("GPL v2");
>
> These three macros will be preprocessed away. (And I guess you could
> also drop the linux/module.h include, but I have
On Thu, Mar 5, 2015 at 1:35 AM, Ray Jui wrote:
> This adds the initial driver support for the Broadcom Cygnus IOMUX
> controller. The Cygnus IOMUX controller supports group based mux
> configuration but allows certain pins to be muxed to GPIO individually
>
> Signed-off-by: Ray Jui
> Reviewed-by
On Wed, 2015-03-04 at 16:35 -0800, Ray Jui wrote:
> diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig
> index bc6d048..eb13201 100644
> --- a/drivers/pinctrl/bcm/Kconfig
> +++ b/drivers/pinctrl/bcm/Kconfig
> @@ -19,3 +19,16 @@ config PINCTRL_BCM2835
> bool
> select
This adds the initial driver support for the Broadcom Cygnus IOMUX
controller. The Cygnus IOMUX controller supports group based mux
configuration but allows certain pins to be muxed to GPIO individually
Signed-off-by: Ray Jui
Reviewed-by: Scott Branden
Tested-by: Dmitry Torokhov
---
drivers/pi
9 matches
Mail list logo
