Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Bryan O'Donoghue
On 26/06/2025 12:17, Vladimir Zapolskiy wrote: What's about MSM8953 then? Should be fixed up to match 8916. We don't have an upstream user and we, I, did the wrong thing. Please see commit c830aff08d51 ("media: dt-bindings: Add qcom,msm8953- camss"). x1e has a particular order if a new de

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Vladimir Zapolskiy
On 6/26/25 13:48, Bryan O'Donoghue wrote: On 26/06/2025 11:28, Krzysztof Kozlowski wrote: On 26/06/2025 12:19, Bryan O'Donoghue wrote: On 26/06/2025 11:00, Krzysztof Kozlowski wrote: + reg-names: +items: + - const: csi_clk_mux No, I already provided arguments in two lengthy discussi

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Bryan O'Donoghue
On 13/06/2025 10:33, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 254

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Bryan O'Donoghue
On 26/06/2025 11:28, Krzysztof Kozlowski wrote: On 26/06/2025 12:19, Bryan O'Donoghue wrote: On 26/06/2025 11:00, Krzysztof Kozlowski wrote: + reg-names: +items: + - const: csi_clk_mux No, I already provided arguments in two lengthy discussions - this is not sorted by name. Keep the

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Krzysztof Kozlowski
On 26/06/2025 12:19, Bryan O'Donoghue wrote: > On 26/06/2025 11:00, Krzysztof Kozlowski wrote: >>> + reg-names: >>> +items: >>> + - const: csi_clk_mux >> No, I already provided arguments in two lengthy discussions - this is >> not sorted by name. >> >> Keep the same order as in previous d

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Bryan O'Donoghue
On 26/06/2025 11:00, Krzysztof Kozlowski wrote: + reg-names: +items: + - const: csi_clk_mux No, I already provided arguments in two lengthy discussions - this is not sorted by name. Keep the same order as in previous device, so msm8916 for example. Or any other, but listen to some req

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Krzysztof Kozlowski
On 13/06/2025 11:33, Vincent Knecht via B4 Relay wrote: > From: Vincent Knecht > > Add bindings for qcom,msm8939-camss in order to support the camera > subsystem for MSM8939. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Vincent Knecht > --- Also, still incorrect order of patches. Bind

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Krzysztof Kozlowski
On 13/06/2025 11:33, Vincent Knecht via B4 Relay wrote: > From: Vincent Knecht > > Add bindings for qcom,msm8939-camss in order to support the camera > subsystem for MSM8939. > > Reviewed-by: Krzysztof Kozlowski Drop, you did here some unusual changes. > Signed-off-by: Vincent Knecht > --- >

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-13 Thread Vladimir Zapolskiy
On 6/13/25 12:33, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-13 Thread Bryan O'Donoghue
On 13/06/2025 10:33, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 254

[PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-13 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 254 + 1 file changed, 254 insertions(+)