Re: [PATCH v5 3/3] vfio/pci: Decouple PCI_COMMAND_MEMORY bit checks from is_virtfn

2020-09-23 Thread Pierre Morel
On 2020-09-22 18:40, Alex Williamson wrote: On Mon, 21 Sep 2020 08:43:29 -0400 Matthew Rosato wrote: On 9/10/20 10:59 AM, Matthew Rosato wrote: While it is true that devices with is_virtfn=1 will have a Memory Space Enable bit that is hard-wired to 0, this is not the only case where we see

Re: [PATCH v5 3/3] vfio/pci: Decouple PCI_COMMAND_MEMORY bit checks from is_virtfn

2020-09-22 Thread Matthew Rosato
On 9/22/20 12:40 PM, Alex Williamson wrote: On Mon, 21 Sep 2020 08:43:29 -0400 Matthew Rosato wrote: On 9/10/20 10:59 AM, Matthew Rosato wrote: While it is true that devices with is_virtfn=1 will have a Memory Space Enable bit that is hard-wired to 0, this is not the only case where we see th

Re: [PATCH v5 3/3] vfio/pci: Decouple PCI_COMMAND_MEMORY bit checks from is_virtfn

2020-09-22 Thread Alex Williamson
On Mon, 21 Sep 2020 08:43:29 -0400 Matthew Rosato wrote: > On 9/10/20 10:59 AM, Matthew Rosato wrote: > > While it is true that devices with is_virtfn=1 will have a Memory Space > > Enable bit that is hard-wired to 0, this is not the only case where we > > see this behavior -- For example some ba

Re: [PATCH v5 3/3] vfio/pci: Decouple PCI_COMMAND_MEMORY bit checks from is_virtfn

2020-09-21 Thread Matthew Rosato
On 9/10/20 10:59 AM, Matthew Rosato wrote: While it is true that devices with is_virtfn=1 will have a Memory Space Enable bit that is hard-wired to 0, this is not the only case where we see this behavior -- For example some bare-metal hypervisors lack Memory Space Enable bit emulation for devices

[PATCH v5 3/3] vfio/pci: Decouple PCI_COMMAND_MEMORY bit checks from is_virtfn

2020-09-10 Thread Matthew Rosato
While it is true that devices with is_virtfn=1 will have a Memory Space Enable bit that is hard-wired to 0, this is not the only case where we see this behavior -- For example some bare-metal hypervisors lack Memory Space Enable bit emulation for devices not setting is_virtfn (s390). Fix this by in