Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-08 Thread Nick Crews
I've just found a few [embarrassing :)] bugs in this version, so after we figure out the naming, please wait for me to send out another patch that fixes these. Thanks, Nick On Thu, Apr 4, 2019 at 11:10 AM Nick Crews wrote: > > We want all backlights for the system keyboard to > use a common name

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-08 Thread Jacek Anaszewski
Hi Dmitry, Thanks for the review. On 4/8/19 12:01 AM, Dmitry Torokhov wrote: Hi Jacek, On Fri, Apr 5, 2019 at 1:00 PM Jacek Anaszewski wrote: Hi all, On 4/5/19 10:42 AM, Enric Balletbo i Serra wrote: Hi, On 5/4/19 0:42, Guenter Roeck wrote: On Thu, Apr 4, 2019 at 3:05 PM Pavel Machek w

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-07 Thread Dmitry Torokhov
Hi Jacek, On Fri, Apr 5, 2019 at 1:00 PM Jacek Anaszewski wrote: > > Hi all, > > On 4/5/19 10:42 AM, Enric Balletbo i Serra wrote: > > Hi, > > > > On 5/4/19 0:42, Guenter Roeck wrote: > >> On Thu, Apr 4, 2019 at 3:05 PM Pavel Machek wrote: > >>> > >>> On Thu 2019-04-04 14:48:35, Dmitry Torokhov

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-06 Thread Pavel Machek
Hi! > >I am not sure about existing driver. Important thing for me is that > >new drivers use consistent naming. > > > >>In cases like above: > >> > >> keyboardist::kbd_backlight > >> tclnumpad::kbd_backlight > >> > >>we could do with the following: > >> > >> :kbd-backlight > >> :n

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-06 Thread Jacek Anaszewski
Hi Pavel, On 4/6/19 11:53 AM, Pavel Machek wrote: Hi! The patch set introduces also a set of predefined LED_FUNCTION names to be used in DT bindings. This along with the removal of devicename section from LED naming pattern will help to keep LED sysfs interface more uniform and not varying dep

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-06 Thread Pavel Machek
Hi! > The patch set introduces also a set of predefined LED_FUNCTION > names to be used in DT bindings. This along with the removal > of devicename section from LED naming pattern will help to keep > LED sysfs interface more uniform and not varying depending on > underlaying hardware driving the L

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-05 Thread Jacek Anaszewski
Hi all, On 4/5/19 10:42 AM, Enric Balletbo i Serra wrote: Hi, On 5/4/19 0:42, Guenter Roeck wrote: On Thu, Apr 4, 2019 at 3:05 PM Pavel Machek wrote: On Thu 2019-04-04 14:48:35, Dmitry Torokhov wrote: On Thu, Apr 4, 2019 at 1:42 PM Pavel Machek wrote: Hi! And what to do if internal ke

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-05 Thread Enric Balletbo i Serra
Hi, On 5/4/19 0:42, Guenter Roeck wrote: > On Thu, Apr 4, 2019 at 3:05 PM Pavel Machek wrote: >> >> On Thu 2019-04-04 14:48:35, Dmitry Torokhov wrote: >>> On Thu, Apr 4, 2019 at 1:42 PM Pavel Machek wrote: Hi! >>> And what to do if internal keyboard is not platform but USB? Li

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Guenter Roeck
On Thu, Apr 4, 2019 at 3:05 PM Pavel Machek wrote: > > On Thu 2019-04-04 14:48:35, Dmitry Torokhov wrote: > > On Thu, Apr 4, 2019 at 1:42 PM Pavel Machek wrote: > > > > > > Hi! > > > > > > > > > And what to do if internal keyboard is not platform but USB? Like > > > > > > Google "Whiskers"? (I am

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Pavel Machek
On Thu 2019-04-04 14:48:35, Dmitry Torokhov wrote: > On Thu, Apr 4, 2019 at 1:42 PM Pavel Machek wrote: > > > > Hi! > > > > > > > And what to do if internal keyboard is not platform but USB? Like > > > > > Google "Whiskers"? (I am not sure why you decided to drop my mention > > > > > of internal U

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Dmitry Torokhov
On Thu, Apr 4, 2019 at 1:42 PM Pavel Machek wrote: > > Hi! > > > > > And what to do if internal keyboard is not platform but USB? Like > > > > Google "Whiskers"? (I am not sure why you decided to drop my mention > > > > of internal USB keyboards completely off your reply). > > > > > > I don't have

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Pavel Machek
Hi! > > > And what to do if internal keyboard is not platform but USB? Like > > > Google "Whiskers"? (I am not sure why you decided to drop my mention > > > of internal USB keyboards completely off your reply). > > > > I don't have answers for everything. Even if you have USB keyboard, you'll > >

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Dmitry Torokhov
On Thu, Apr 4, 2019 at 1:20 PM Pavel Machek wrote: > > On Thu 2019-04-04 13:13:34, Dmitry Torokhov wrote: > > On Thu, Apr 4, 2019 at 1:06 PM Pavel Machek wrote: > > > > > > Hi! > > > > > > > > > It is *function* and maybe color that userspace is interested in, > > > > > > and > > > > > > here we

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Pavel Machek
On Thu 2019-04-04 13:13:34, Dmitry Torokhov wrote: > On Thu, Apr 4, 2019 at 1:06 PM Pavel Machek wrote: > > > > Hi! > > > > > > > It is *function* and maybe color that userspace is interested in, and > > > > > here we have proper standardization in form of "kbd_backlight". Device > > > > > name is

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Dmitry Torokhov
On Thu, Apr 4, 2019 at 1:06 PM Pavel Machek wrote: > > Hi! > > > > > It is *function* and maybe color that userspace is interested in, and > > > > here we have proper standardization in form of "kbd_backlight". Device > > > > name is, well, device name. It should uniquely identify the device led >

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Pavel Machek
Hi! > > > It is *function* and maybe color that userspace is interested in, and > > > here we have proper standardization in form of "kbd_backlight". Device > > > name is, well, device name. It should uniquely identify the device led > > > is attached to, but otherwise is rarely interesting. If us

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Dmitry Torokhov
On Thu, Apr 4, 2019 at 12:19 PM Pavel Machek wrote: > > On Thu 2019-04-04 12:05:39, Dmitry Torokhov wrote: > > On Thu, Apr 4, 2019 at 11:59 AM Pavel Machek wrote: > > > > > > On Thu 2019-04-04 11:55:27, Dmitry Torokhov wrote: > > > > On Thu, Apr 4, 2019 at 11:41 AM Nick Crews wrote: > > > > > >

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Pavel Machek
On Thu 2019-04-04 12:05:39, Dmitry Torokhov wrote: > On Thu, Apr 4, 2019 at 11:59 AM Pavel Machek wrote: > > > > On Thu 2019-04-04 11:55:27, Dmitry Torokhov wrote: > > > On Thu, Apr 4, 2019 at 11:41 AM Nick Crews wrote: > > > > > > > > On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > >

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Dmitry Torokhov
On Thu, Apr 4, 2019 at 11:59 AM Pavel Machek wrote: > > On Thu 2019-04-04 11:55:27, Dmitry Torokhov wrote: > > On Thu, Apr 4, 2019 at 11:41 AM Nick Crews wrote: > > > > > > On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > > > > > > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wrote

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Pavel Machek
On Thu 2019-04-04 11:55:27, Dmitry Torokhov wrote: > On Thu, Apr 4, 2019 at 11:41 AM Nick Crews wrote: > > > > On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > > > > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wrote: > > > > > > > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wrote

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Pavel Machek
Hi! > You're right, I should have been more precise. > I was referring to Pavel, Enric, and myself. Pavel had this opinion here: > https://lkml.org/lkml/2019/4/4/1040. I don't know what Pavel meant by "we" > in that comment, but I would guess that could mean the other LED maintainers > as well? I

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Dmitry Torokhov
On Thu, Apr 4, 2019 at 11:41 AM Nick Crews wrote: > > On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wrote: > > > > > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wrote: > > > > > > > > We want all backlights for the system keyboard

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Nick Crews
On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wrote: > > > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wrote: > > > > > > We want all backlights for the system keyboard to > > > use a common name, so the name "platform::kbd_backlight" >

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Dmitry Torokhov
On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wrote: > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wrote: > > > > We want all backlights for the system keyboard to > > use a common name, so the name "platform::kbd_backlight" > > would be better than the current "chromeos::kbd_backlight" > > name

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Guenter Roeck
On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wrote: > > We want all backlights for the system keyboard to > use a common name, so the name "platform::kbd_backlight" > would be better than the current "chromeos::kbd_backlight" > name. Normally this wouldn't be worth changing, but the new > Wilco keyb

[PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-04 Thread Nick Crews
We want all backlights for the system keyboard to use a common name, so the name "platform::kbd_backlight" would be better than the current "chromeos::kbd_backlight" name. Normally this wouldn't be worth changing, but the new Wilco keyboard backlight driver uses the "platform" name. We want to make