Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-14 Thread Luis R. Rodriguez
On Mon, Nov 14, 2016 at 7:48 AM, Lukas Wunner wrote: > On Mon, Nov 14, 2016 at 02:48:32PM +0100, Luis R. Rodriguez wrote: >> On Sun, Nov 13, 2016 at 06:34:13PM +0100, Lukas Wunner wrote: >> > On Mon, Nov 07, 2016 at 10:39:54PM +0100, Luis R. Rodriguez wrote: >> > > On Mon, Oct 10, 2016 at 02:51:04

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-14 Thread Lukas Wunner
On Mon, Nov 14, 2016 at 02:48:32PM +0100, Luis R. Rodriguez wrote: > On Sun, Nov 13, 2016 at 06:34:13PM +0100, Lukas Wunner wrote: > > On Mon, Nov 07, 2016 at 10:39:54PM +0100, Luis R. Rodriguez wrote: > > > On Mon, Oct 10, 2016 at 02:51:04PM +0200, Rafael J. Wysocki wrote: > > > > One of the actio

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-14 Thread Luis R. Rodriguez
On Sun, Nov 13, 2016 at 11:59:42AM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 11, 2016 at 02:08:35AM +0200, Laurent Pinchart wrote: > > Hi Greg, > > > > On Thursday 10 Nov 2016 23:40:54 Greg Kroah-Hartman wrote: > > > On Thu, Nov 10, 2016 at 11:04:07PM +0100, Luis R. Rodriguez wrote: > > > > T

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-14 Thread Luis R. Rodriguez
On Sun, Nov 13, 2016 at 06:34:13PM +0100, Lukas Wunner wrote: > On Mon, Nov 07, 2016 at 10:39:54PM +0100, Luis R. Rodriguez wrote: > > On Mon, Oct 10, 2016 at 02:51:04PM +0200, Rafael J. Wysocki wrote: > > > One of the actions carried out by device_link_add() is to reorder > > > the lists used for

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-14 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Nov 11, 2016 at 1:08 AM, Laurent Pinchart wrote: > On Thursday 10 Nov 2016 23:40:54 Greg Kroah-Hartman wrote: >> On Thu, Nov 10, 2016 at 11:04:07PM +0100, Luis R. Rodriguez wrote: >> Don't try to make this more difficult than it is please. DEFER works >> today really really we

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-13 Thread Lukas Wunner
On Mon, Nov 07, 2016 at 10:39:54PM +0100, Luis R. Rodriguez wrote: > On Mon, Oct 10, 2016 at 02:51:04PM +0200, Rafael J. Wysocki wrote: > > One of the actions carried out by device_link_add() is to reorder > > the lists used for device shutdown and system suspend/resume to > > put the consumer devi

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-13 Thread Lukas Wunner
On Tue, Nov 08, 2016 at 09:58:24PM +0100, Luis R. Rodriguez wrote: > On Tue, Nov 08, 2016 at 08:43:35PM +0100, Greg Kroah-Hartman wrote: > > Yes, you can iterate a > > lot of times, but that's fine, we have time at boot to do that (and > > really, it is fast.) > > Deferred probe is left for late_i

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-13 Thread Greg Kroah-Hartman
On Fri, Nov 11, 2016 at 02:08:35AM +0200, Laurent Pinchart wrote: > Hi Greg, > > On Thursday 10 Nov 2016 23:40:54 Greg Kroah-Hartman wrote: > > On Thu, Nov 10, 2016 at 11:04:07PM +0100, Luis R. Rodriguez wrote: > > > This is more forward looking, but -- if we had an annotation in > > > Kconfig/tur

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-10 Thread Laurent Pinchart
Hi Greg, On Thursday 10 Nov 2016 23:40:54 Greg Kroah-Hartman wrote: > On Thu, Nov 10, 2016 at 11:04:07PM +0100, Luis R. Rodriguez wrote: > > This is more forward looking, but -- if we had an annotation in > > Kconfig/turned to a mod info section, or to start off with just a driver > > MODULE_SUGGE

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-10 Thread Luis R. Rodriguez
On Thu, Nov 10, 2016 at 09:05:30AM +0200, Laurent Pinchart wrote: > Hi Luis, > > On Monday 07 Nov 2016 22:39:54 Luis R. Rodriguez wrote: > > On Mon, Oct 10, 2016 at 02:51:04PM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Currently, there is a problem with taking func

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-10 Thread Greg Kroah-Hartman
On Thu, Nov 10, 2016 at 11:04:07PM +0100, Luis R. Rodriguez wrote: > This is more forward looking, but -- if we had an annotation in Kconfig/turned > to a mod info section, or to start off with just a driver MODULE_SUGGESTS() > macro > to start off with it might suffice for the driver core to requ

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-10 Thread Luis R. Rodriguez
On Thu, Nov 10, 2016 at 09:46:42AM +0100, Geert Uytterhoeven wrote: > On Thu, Nov 10, 2016 at 1:59 AM, Luis R. Rodriguez wrote: > > On Wed, Nov 9, 2016 at 4:43 PM, Rafael J. Wysocki wrote: > >> On Mon, Nov 7, 2016 at 10:22 PM, Luis R. Rodriguez > >> wrote: > >>> As clarified by Rafael at Plumbe

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-10 Thread Luis R. Rodriguez
On Thu, Nov 10, 2016 at 09:14:32AM +0200, Laurent Pinchart wrote: > Hi Luis, > > On Wednesday 09 Nov 2016 16:59:30 Luis R. Rodriguez wrote: > > On Wed, Nov 9, 2016 at 4:43 PM, Rafael J. Wysocki wrote: > > > On Mon, Nov 7, 2016 at 10:22 PM, Luis R. Rodriguez wrote: > > >> On Thu, Oct 27, 2016 at 05

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-10 Thread Geert Uytterhoeven
On Thu, Nov 10, 2016 at 1:59 AM, Luis R. Rodriguez wrote: > On Wed, Nov 9, 2016 at 4:43 PM, Rafael J. Wysocki wrote: >> On Mon, Nov 7, 2016 at 10:22 PM, Luis R. Rodriguez wrote: >>> As clarified by Rafael at Plumbers, this functional dependencies >>> framework assumes your driver / subsystem sup

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-09 Thread Laurent Pinchart
Hi Luis, On Wednesday 09 Nov 2016 16:59:30 Luis R. Rodriguez wrote: > On Wed, Nov 9, 2016 at 4:43 PM, Rafael J. Wysocki wrote: > > On Mon, Nov 7, 2016 at 10:22 PM, Luis R. Rodriguez wrote: > >> On Thu, Oct 27, 2016 at 05:25:51PM +0200, Greg Kroah-Hartman wrote: > >>> On Wed, Oct 26, 2016 at 01:19:

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-09 Thread Laurent Pinchart
Hi Luis, On Monday 07 Nov 2016 22:39:54 Luis R. Rodriguez wrote: > On Mon, Oct 10, 2016 at 02:51:04PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Currently, there is a problem with taking functional dependencies > > between devices into account. > > > > What I mean by a

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-09 Thread Rafael J. Wysocki
On Mon, Nov 7, 2016 at 10:39 PM, Luis R. Rodriguez wrote: > On Mon, Oct 10, 2016 at 02:51:04PM +0200, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> Currently, there is a problem with taking functional dependencies >> between devices into account. >> >> What I mean by a "functional dep

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-09 Thread Luis R. Rodriguez
On Wed, Nov 9, 2016 at 4:43 PM, Rafael J. Wysocki wrote: > On Mon, Nov 7, 2016 at 10:22 PM, Luis R. Rodriguez wrote: >> On Thu, Oct 27, 2016 at 05:25:51PM +0200, Greg Kroah-Hartman wrote: >>> On Wed, Oct 26, 2016 at 01:19:02PM +0200, Lukas Wunner wrote: >>> > Hi Rafael, >>> > >>> > sorry for not

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-09 Thread Rafael J. Wysocki
On Mon, Nov 7, 2016 at 10:22 PM, Luis R. Rodriguez wrote: > On Thu, Oct 27, 2016 at 05:25:51PM +0200, Greg Kroah-Hartman wrote: >> On Wed, Oct 26, 2016 at 01:19:02PM +0200, Lukas Wunner wrote: >> > Hi Rafael, >> > >> > sorry for not responding to v5 of your series earlier, just sending >> > this o

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-09 Thread Greg Kroah-Hartman
On Wed, Nov 09, 2016 at 10:36:54AM +0100, Andrzej Hajda wrote: > On 09.11.2016 07:45, Greg Kroah-Hartman wrote: > > On Tue, Nov 08, 2016 at 09:58:24PM +0100, Luis R. Rodriguez wrote: > Furthermore -- how does this framework compare to Andrzej's resource > tracking > solution? I conf

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-09 Thread Andrzej Hajda
On 09.11.2016 07:45, Greg Kroah-Hartman wrote: > On Tue, Nov 08, 2016 at 09:58:24PM +0100, Luis R. Rodriguez wrote: Furthermore -- how does this framework compare to Andrzej's resource tracking solution? I confess I have not had a chance yet to review yet but in light of

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-08 Thread Greg Kroah-Hartman
On Tue, Nov 08, 2016 at 09:58:24PM +0100, Luis R. Rodriguez wrote: > > > Furthermore -- how does this framework compare to Andrzej's resource > > > tracking > > > solution? I confess I have not had a chance yet to review yet but in > > > light of > > > this question it would be good to know if An

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-08 Thread Luis R. Rodriguez
On Tue, Nov 08, 2016 at 08:43:35PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 08, 2016 at 08:21:04PM +0100, Luis R. Rodriguez wrote: > > On Tue, Nov 08, 2016 at 07:45:41AM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Nov 07, 2016 at 10:22:50PM +0100, Luis R. Rodriguez wrote: > > > > We have n

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-08 Thread Greg Kroah-Hartman
On Tue, Nov 08, 2016 at 08:21:04PM +0100, Luis R. Rodriguez wrote: > On Tue, Nov 08, 2016 at 07:45:41AM +0100, Greg Kroah-Hartman wrote: > > On Mon, Nov 07, 2016 at 10:22:50PM +0100, Luis R. Rodriguez wrote: > > > We have no explicit semantics to check if a driver / subsystem > > > supports deferre

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-08 Thread Luis R. Rodriguez
On Tue, Nov 08, 2016 at 07:45:41AM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 07, 2016 at 10:22:50PM +0100, Luis R. Rodriguez wrote: > > We have no explicit semantics to check if a driver / subsystem > > supports deferred probe. > > Why would we need such a thing? It depends on the impact of

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-07 Thread Greg Kroah-Hartman
On Mon, Nov 07, 2016 at 10:22:50PM +0100, Luis R. Rodriguez wrote: > We have no explicit semantics to check if a driver / subsystem > supports deferred probe. Why would we need such a thing? thanks, greg k-h

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-07 Thread Luis R. Rodriguez
On Mon, Oct 10, 2016 at 02:51:04PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Currently, there is a problem with taking functional dependencies > between devices into account. > > What I mean by a "functional dependency" is when the driver of device > B needs device A to be fu

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-11-07 Thread Luis R. Rodriguez
On Thu, Oct 27, 2016 at 05:25:51PM +0200, Greg Kroah-Hartman wrote: > On Wed, Oct 26, 2016 at 01:19:02PM +0200, Lukas Wunner wrote: > > Hi Rafael, > > > > sorry for not responding to v5 of your series earlier, just sending > > this out now in the hope that it reaches you before your travels. > >

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-10-28 Thread Lukas Wunner
On Thu, Oct 27, 2016 at 05:25:51PM +0200, Greg Kroah-Hartman wrote: > On Wed, Oct 26, 2016 at 01:19:02PM +0200, Lukas Wunner wrote: > > On Mon, Oct 10, 2016 at 02:51:04PM +0200, Rafael J. Wysocki wrote: > > > - Modify device_links_check_suppliers(), device_links_driver_bound(), > > > device_links

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-10-27 Thread Greg Kroah-Hartman
On Mon, Oct 10, 2016 at 02:51:04PM +0200, Rafael J. Wysocki wrote: > +/* > + * Device link flags. > + * > + * STATELESS: The core won't track the presence of supplier/consumer drivers. > + * AUTOREMOVE: Remove this link automatically on consumer driver unbind. > + */ > +#define DL_FLAG_STATELESS

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-10-27 Thread Greg Kroah-Hartman
On Wed, Oct 26, 2016 at 01:19:02PM +0200, Lukas Wunner wrote: > Hi Rafael, > > sorry for not responding to v5 of your series earlier, just sending > this out now in the hope that it reaches you before your travels. > > On Mon, Oct 10, 2016 at 02:51:04PM +0200, Rafael J. Wysocki wrote: > > - Modif

Re: [PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-10-26 Thread Lukas Wunner
Hi Rafael, sorry for not responding to v5 of your series earlier, just sending this out now in the hope that it reaches you before your travels. On Mon, Oct 10, 2016 at 02:51:04PM +0200, Rafael J. Wysocki wrote: > - Modify device_links_check_suppliers(), device_links_driver_bound(), > device_li

[PATCH v5 2/5] driver core: Functional dependencies tracking support

2016-10-10 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Currently, there is a problem with taking functional dependencies between devices into account. What I mean by a "functional dependency" is when the driver of device B needs device A to be functional and (generally) its driver to be present in order to work properly. Thi