Re: [PATCH v5 2/4] virtio_rtc: Add PTP clocks

2025-02-25 Thread Michael S. Tsirkin
On Tue, Feb 25, 2025 at 02:12:40PM +, Simon Horman wrote: > On Tue, Feb 25, 2025 at 12:28:24PM +0100, Peter Hilber wrote: > > On Mon, Feb 24, 2025 at 05:56:18PM +, Simon Horman wrote: > > > On Wed, Feb 19, 2025 at 08:32:57PM +0100, Peter Hilber wrote: > > > > > > ... > > > > > > > +/** >

Re: [PATCH v5 2/4] virtio_rtc: Add PTP clocks

2025-02-25 Thread Simon Horman
On Tue, Feb 25, 2025 at 12:28:24PM +0100, Peter Hilber wrote: > On Mon, Feb 24, 2025 at 05:56:18PM +, Simon Horman wrote: > > On Wed, Feb 19, 2025 at 08:32:57PM +0100, Peter Hilber wrote: > > > > ... > > > > > +/** > > > + * viortc_ptp_gettimex64() - PTP clock gettimex64 op > > > + * > > > >

Re: [PATCH v5 2/4] virtio_rtc: Add PTP clocks

2025-02-25 Thread Peter Hilber
On Mon, Feb 24, 2025 at 05:56:18PM +, Simon Horman wrote: > On Wed, Feb 19, 2025 at 08:32:57PM +0100, Peter Hilber wrote: > > ... > > > +/** > > + * viortc_ptp_gettimex64() - PTP clock gettimex64 op > > + * > > Hi Peter, > > Tooling recognises this as a kernel doc, and complains > that ther

Re: [PATCH v5 2/4] virtio_rtc: Add PTP clocks

2025-02-24 Thread Simon Horman
On Wed, Feb 19, 2025 at 08:32:57PM +0100, Peter Hilber wrote: ... > +/** > + * viortc_ptp_gettimex64() - PTP clock gettimex64 op > + * Hi Peter, Tooling recognises this as a kernel doc, and complains that there is no documentation present for the function's parameters: ptp, ts, and sts. Flagge

[PATCH v5 2/4] virtio_rtc: Add PTP clocks

2025-02-19 Thread Peter Hilber
Expose the virtio_rtc clocks as PTP clocks to userspace, similar to ptp_kvm. virtio_rtc can expose multiple clocks, e.g. a UTC clock and a monotonic clock. Userspace should distinguish different clocks through the name assigned by the driver. In particular, UTC-like clocks can also be distinguishe