Re: [PATCH v5 2/3] z3fold: remove redundant locking

2016-10-17 Thread Vitaly Wool
On Mon, Oct 17, 2016 at 10:48 PM, Dan Streetman wrote: > On Sat, Oct 15, 2016 at 7:59 AM, Vitaly Wool wrote: >> The per-pool z3fold spinlock should generally be taken only when >> a non-atomic pool variable is modified. There's no need to take it >> to map/unmap an object. > > no. it absolutely

Re: [PATCH v5 2/3] z3fold: remove redundant locking

2016-10-17 Thread Dan Streetman
On Sat, Oct 15, 2016 at 7:59 AM, Vitaly Wool wrote: > The per-pool z3fold spinlock should generally be taken only when > a non-atomic pool variable is modified. There's no need to take it > to map/unmap an object. no. it absolutely needs to be taken, because z3fold_compact_page could move the mi

[PATCH v5 2/3] z3fold: remove redundant locking

2016-10-15 Thread Vitaly Wool
The per-pool z3fold spinlock should generally be taken only when a non-atomic pool variable is modified. There's no need to take it to map/unmap an object. Signed-off-by: Vitaly Wool --- mm/z3fold.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/mm/z3fold.