Re: [PATCH v5 2/2] scanf: break kunit into test cases

On Mon, Feb 10, 2025 at 11:27 AM Geert Uytterhoeven wrote: > > > [...] > > > > -static char *test_buffer; > > -static char *fmt_buffer; > > +static char test_buffer[BUF_SIZE]; > > +static char fmt_buffer[BUF_SIZE]; > > Why? This wastes 2 KiB of memory when the test is not running. It's a fair poi

Re: [PATCH v5 2/2] scanf: break kunit into test cases

Hi Tamir, On Mon, 10 Feb 2025 at 16:00, Tamir Duberstein wrote: > Use `suite_init` and move some tests into `scanf_test_cases`. This > gives us nicer output in the event of a failure. > > Reviewed-by: David Gow > Signed-off-by: Tamir Duberstein Thanks for your patch! > --- a/lib/scanf_kunit.c

[PATCH v5 2/2] scanf: break kunit into test cases

Use `suite_init` and move some tests into `scanf_test_cases`. This gives us nicer output in the event of a failure. Reviewed-by: David Gow Signed-off-by: Tamir Duberstein --- lib/scanf_kunit.c | 98 +-- 1 file changed, 44 insertions(+), 54 del