Re: [PATCH v5 2/2] mmc: sdhci-msm: Actually set the actual clock

2021-01-11 Thread Ulf Hansson
On Mon, 14 Dec 2020 at 18:23, Douglas Anderson wrote: > > The MSM SDHCI driver always set the "actual_clock" field to 0. It had > a comment about it not being needed because we weren't using the > standard SDHCI divider mechanism and we'd just fallback to > "host->clock". However, it's still bet

Re: [PATCH v5 2/2] mmc: sdhci-msm: Actually set the actual clock

2020-12-15 Thread Veerabhadrarao Badiganti
On 12/14/2020 10:51 PM, Douglas Anderson wrote: The MSM SDHCI driver always set the "actual_clock" field to 0. It had a comment about it not being needed because we weren't using the standard SDHCI divider mechanism and we'd just fallback to "host->clock". However, it's still better to provid

Re: [PATCH v5 2/2] mmc: sdhci-msm: Actually set the actual clock

2020-12-15 Thread Adrian Hunter
On 14/12/20 7:21 pm, Douglas Anderson wrote: > The MSM SDHCI driver always set the "actual_clock" field to 0. It had > a comment about it not being needed because we weren't using the > standard SDHCI divider mechanism and we'd just fallback to > "host->clock". However, it's still better to provi

[PATCH v5 2/2] mmc: sdhci-msm: Actually set the actual clock

2020-12-14 Thread Douglas Anderson
The MSM SDHCI driver always set the "actual_clock" field to 0. It had a comment about it not being needed because we weren't using the standard SDHCI divider mechanism and we'd just fallback to "host->clock". However, it's still better to provide the actual clock. Why? 1. It will make timeout c