Re: [PATCH v5 2/2] lib/prime_numbers: convert self-test to KUnit

2025-02-11 Thread Tamir Duberstein
On Tue, Feb 11, 2025 at 11:38 AM Kees Cook wrote: > > On Tue, Feb 11, 2025 at 06:51:09AM -0500, Tamir Duberstein wrote: > > Kees, it looks like the private header didn't make it to your tree. > > This bit is missing: > > Whoops! Thanks. I've added it (and fixed the comment style). > > I really nee

Re: [PATCH v5 2/2] lib/prime_numbers: convert self-test to KUnit

2025-02-11 Thread Kees Cook
On Tue, Feb 11, 2025 at 06:51:09AM -0500, Tamir Duberstein wrote: > Kees, it looks like the private header didn't make it to your tree. > This bit is missing: Whoops! Thanks. I've added it (and fixed the comment style). I really need to do my build/run testing from a fresh checkout instead of in

Re: [PATCH v5 2/2] lib/prime_numbers: convert self-test to KUnit

2025-02-11 Thread Tamir Duberstein
Kees, it looks like the private header didn't make it to your tree. This bit is missing: diff --git a/lib/math/prime_numbers.c b/lib/math/prime_numbers.c index f88d6e64dbdc..de59f001c8c7 100644 --- a/lib/math/prime_numbers.c +++ b/lib/math/prime_numbers.c @@ -58,6 +58,7 @@ static DEFINE_MUTEX(lock

Re: [PATCH v5 2/2] lib/prime_numbers: convert self-test to KUnit

2025-02-10 Thread Tamir Duberstein
Ah, I see https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/move-kunit-tests&id=3e50ba8fc834cadead733e4feeb969fce2f3b6e1 now. On Mon, Feb 10, 2025 at 9:47 PM Tamir Duberstein wrote: > > On Mon, Feb 10, 2025 at 9:37 PM Kees Cook wrote: > > > > On Sat, Feb 08, 2025

Re: [PATCH v5 2/2] lib/prime_numbers: convert self-test to KUnit

2025-02-10 Thread Tamir Duberstein
On Mon, Feb 10, 2025 at 9:37 PM Kees Cook wrote: > > On Sat, Feb 08, 2025 at 09:44:39PM -0500, Tamir Duberstein wrote: > > Extract a private header and convert the prime_numbers self-test to a > > KUnit test. I considered parameterizing the test using > > `KUNIT_CASE_PARAM` but didn't see how it w

Re: [PATCH v5 2/2] lib/prime_numbers: convert self-test to KUnit

2025-02-10 Thread Kees Cook
On Sat, Feb 08, 2025 at 09:44:39PM -0500, Tamir Duberstein wrote: > Extract a private header and convert the prime_numbers self-test to a > KUnit test. I considered parameterizing the test using > `KUNIT_CASE_PARAM` but didn't see how it was possible since the test > logic is entangled with the tes

[PATCH v5 2/2] lib/prime_numbers: convert self-test to KUnit

2025-02-08 Thread Tamir Duberstein
Extract a private header and convert the prime_numbers self-test to a KUnit test. I considered parameterizing the test using `KUNIT_CASE_PARAM` but didn't see how it was possible since the test logic is entangled with the test parameter generation logic. Signed-off-by: Tamir Duberstein --- lib/K