Re: [PATCH v5 14/14] memory-hotplug: free node_data when a node is offlined

2013-01-06 Thread Kamezawa Hiroyuki
(2012/12/30 15:02), Wen Congyang wrote: > At 12/28/2012 08:28 AM, Kamezawa Hiroyuki Wrote: >> (2012/12/27 21:16), Wen Congyang wrote: >>> At 12/26/2012 11:55 AM, Kamezawa Hiroyuki Wrote: (2012/12/24 21:09), Tang Chen wrote: > From: Wen Congyang > > We call hotadd_new_pgdat() to al

Re: [PATCH v5 14/14] memory-hotplug: free node_data when a node is offlined

2012-12-29 Thread Wen Congyang
At 12/28/2012 08:28 AM, Kamezawa Hiroyuki Wrote: > (2012/12/27 21:16), Wen Congyang wrote: >> At 12/26/2012 11:55 AM, Kamezawa Hiroyuki Wrote: >>> (2012/12/24 21:09), Tang Chen wrote: From: Wen Congyang We call hotadd_new_pgdat() to allocate memory to store node_data. So we sho

Re: [PATCH v5 14/14] memory-hotplug: free node_data when a node is offlined

2012-12-27 Thread Kamezawa Hiroyuki
(2012/12/27 21:16), Wen Congyang wrote: > At 12/26/2012 11:55 AM, Kamezawa Hiroyuki Wrote: >> (2012/12/24 21:09), Tang Chen wrote: >>> From: Wen Congyang >>> >>> We call hotadd_new_pgdat() to allocate memory to store node_data. So we >>> should free it when removing a node. >>> >>> Signed-off-by:

Re: [PATCH v5 14/14] memory-hotplug: free node_data when a node is offlined

2012-12-27 Thread Wen Congyang
At 12/26/2012 11:55 AM, Kamezawa Hiroyuki Wrote: > (2012/12/24 21:09), Tang Chen wrote: >> From: Wen Congyang >> >> We call hotadd_new_pgdat() to allocate memory to store node_data. So we >> should free it when removing a node. >> >> Signed-off-by: Wen Congyang > > I'm sorry but is it safe to re

Re: [PATCH v5 14/14] memory-hotplug: free node_data when a node is offlined

2012-12-25 Thread Kamezawa Hiroyuki
(2012/12/24 21:09), Tang Chen wrote: > From: Wen Congyang > > We call hotadd_new_pgdat() to allocate memory to store node_data. So we > should free it when removing a node. > > Signed-off-by: Wen Congyang I'm sorry but is it safe to remove pgdat ? All zone cache and zonelists are properly clea

[PATCH v5 14/14] memory-hotplug: free node_data when a node is offlined

2012-12-24 Thread Tang Chen
From: Wen Congyang We call hotadd_new_pgdat() to allocate memory to store node_data. So we should free it when removing a node. Signed-off-by: Wen Congyang --- mm/memory_hotplug.c | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/mm/memory_hotplug.c b