Re: [PATCH v5 11/14] ASoC: add simple-graph-card document

2016-12-06 Thread Kuninori Morimoto
Hi Rob > > Do you mean, is this OK for OF graph ? > > Yes, something like this. Wow!! Thanks !! it makes new OF-graph easier !! > > in driver point of view, "I2S" is sound card here. > > Well, that seems odd to me because I2S should just be the h/w block > that interfaces to I2S/SSI signals.

Re: [PATCH v5 11/14] ASoC: add simple-graph-card document

2016-12-06 Thread Rob Herring
On Mon, Dec 5, 2016 at 6:57 PM, Kuninori Morimoto wrote: > > Hi Rob > >> I'd expect the top level node to be the card node that knows how to find >> all the components. The graph should reflect the data flow. For example, >> the data goes to audio DSP to I2S host to codec to amp. > > Do you mean,

Re: [PATCH v5 11/14] ASoC: add simple-graph-card document

2016-12-05 Thread Kuninori Morimoto
Hi Rob > I'd expect the top level node to be the card node that knows how to find > all the components. The graph should reflect the data flow. For example, > the data goes to audio DSP to I2S host to codec to amp. Do you mean, is this OK for OF graph ? in driver point of view, "I2S" is sound

Re: [PATCH v5 11/14] ASoC: add simple-graph-card document

2016-12-05 Thread Rob Herring
On Sun, Dec 04, 2016 at 11:48:49PM +, Kuninori Morimoto wrote: > > Hi Rob, Mark > > > > +++ b/Documentation/devicetree/bindings/sound/simple-graph-card.txt > > > @@ -0,0 +1,67 @@ > > > +Simple-Graph-Card: > > > > There's nothing simple about this. graph-audio-card or audio-card-graph. > > I

Re: [PATCH v5 11/14] ASoC: add simple-graph-card document

2016-12-04 Thread Kuninori Morimoto
Hi Rob, Mark > > > + simple-audio-card,format = "left_j"; > > > + simple-audio-card,bitclock-master = <&ak4643_port>; > > > + simple-audio-card,frame-master = <&ak4643_port>; > > > > If you follow video-interfaces.txt, these should all go in the endpoint > > node. > > H

Re: [PATCH v5 11/14] ASoC: add simple-graph-card document

2016-12-04 Thread Kuninori Morimoto
Hi Rob again > > +Below are same as Simple-Card. > > + > > +- simple-audio-card,name > > +- simple-audio-card,widgets > > +- simple-audio-card,routing > > +- simple-audio-card,mclk-fs > > +- simple-audio-card,hp-det-gpio > > +- simple-audio-card,mic-det-gpio > > +- simple-audio-card,format > > +-

Re: [PATCH v5 11/14] ASoC: add simple-graph-card document

2016-12-04 Thread Kuninori Morimoto
Hi Rob, Mark > > +++ b/Documentation/devicetree/bindings/sound/simple-graph-card.txt > > @@ -0,0 +1,67 @@ > > +Simple-Graph-Card: > > There's nothing simple about this. graph-audio-card or audio-card-graph. I have no objection about naming, but this is one of simple-xxx-card series. And, this i

Re: [PATCH v5 11/14] ASoC: add simple-graph-card document

2016-12-02 Thread Rob Herring
On Mon, Nov 28, 2016 at 02:47:57AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > Signed-off-by: Kuninori Morimoto > --- > .../bindings/sound/simple-graph-card.txt | 67 > ++ > 1 file changed, 67 insertions(+) > create mode 100644 > Documentati

[PATCH v5 11/14] ASoC: add simple-graph-card document

2016-11-27 Thread Kuninori Morimoto
From: Kuninori Morimoto Signed-off-by: Kuninori Morimoto --- .../bindings/sound/simple-graph-card.txt | 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/simple-graph-card.txt diff --git a/Documentation/devicetre