Re: [PATCH v5 10/33] iommu, irq: Allocate irq_desc for dmar_msi with local node

2014-02-22 Thread Yinghai Lu
On Sat, Feb 22, 2014 at 7:33 AM, Jiang Liu wrote: > Hi Yinghai, > I have a plan to test this patch set once I have reviewed > all patches in coming weeks. Do you have a plan to update to latest > kernel or is it ok to test this version? That will be great. I will refresh the branch on top

Re: [PATCH v5 10/33] iommu, irq: Allocate irq_desc for dmar_msi with local node

2014-02-22 Thread Jiang Liu
Hi Yinghai, I have a plan to test this patch set once I have reviewed all patches in coming weeks. Do you have a plan to update to latest kernel or is it ok to test this version? Thanks! Gerry On 2014/2/22 15:44, Yinghai Lu wrote: > On Fri, Feb 21, 2014 at 7:14 PM, Jiang Liu wrote: > >>

Re: [PATCH v5 10/33] iommu, irq: Allocate irq_desc for dmar_msi with local node

2014-02-21 Thread Yinghai Lu
On Fri, Feb 21, 2014 at 7:14 PM, Jiang Liu wrote: > Seems there is no such protection on IA64 side. I feel create_irq_nr() > returns 0 for error is a little risky, 0 may be > a valid IRQ number on other platforms(no sure about this). > Thanks! in [PATCH] ia64, irq: Add dummy create_irq_n

Re: [PATCH v5 10/33] iommu, irq: Allocate irq_desc for dmar_msi with local node

2014-02-21 Thread Jiang Liu
On 2014/2/22 7:18, Yinghai Lu wrote: > On Thu, Feb 20, 2014 at 11:43 PM, Jiang Liu wrote: >> >> >> On 2014/1/3 8:05, Yinghai Lu wrote: >>> iommu irq's irq_desc should be on local node ram. >>> >>> Fix the return value checking problem. >>> create_irq() will return -1 when fail to allocate. >>>

Re: [PATCH v5 10/33] iommu, irq: Allocate irq_desc for dmar_msi with local node

2014-02-21 Thread Yinghai Lu
On Thu, Feb 20, 2014 at 11:43 PM, Jiang Liu wrote: > > > On 2014/1/3 8:05, Yinghai Lu wrote: >> iommu irq's irq_desc should be on local node ram. >> >> Fix the return value checking problem. >> create_irq() will return -1 when fail to allocate. >> create_irq_nr() will return 0 when fail to all

Re: [PATCH v5 10/33] iommu, irq: Allocate irq_desc for dmar_msi with local node

2014-02-20 Thread Jiang Liu
On 2014/1/3 8:05, Yinghai Lu wrote: > iommu irq's irq_desc should be on local node ram. > > Fix the return value checking problem. > create_irq() will return -1 when fail to allocate. > create_irq_nr() will return 0 when fail to allocate. > here only check !irq, so need to change it to use c

[PATCH v5 10/33] iommu, irq: Allocate irq_desc for dmar_msi with local node

2014-01-02 Thread Yinghai Lu
iommu irq's irq_desc should be on local node ram. Fix the return value checking problem. create_irq() will return -1 when fail to allocate. create_irq_nr() will return 0 when fail to allocate. here only check !irq, so need to change it to use create_irq_nr instead. -v2: According to Sebastian