Re: [PATCH v5 10/12] block: Add bio_clone_kmalloc()

2012-08-09 Thread Kent Overstreet
On Wed, Aug 08, 2012 at 11:55:04PM -0700, Tejun Heo wrote: > On Wed, Aug 08, 2012 at 06:57:04PM -0700, Kent Overstreet wrote: > > That means bio_clone_kmalloc will just become: > > > > static inline struct bio *bio_clone_kmalloc(struct bio *bio, > > gfp_t gf

Re: [PATCH v5 10/12] block: Add bio_clone_kmalloc()

2012-08-08 Thread Tejun Heo
On Wed, Aug 08, 2012 at 06:57:04PM -0700, Kent Overstreet wrote: > That means bio_clone_kmalloc will just become: > > static inline struct bio *bio_clone_kmalloc(struct bio *bio, > gfp_t gfp_mask) > { > return bio_clone_bioset(bio, gfp_mask, BIO_KMAL

Re: [PATCH v5 10/12] block: Add bio_clone_kmalloc()

2012-08-08 Thread Kent Overstreet
On Wed, Aug 08, 2012 at 04:15:52PM -0700, Tejun Heo wrote: > On Mon, Aug 06, 2012 at 03:08:39PM -0700, Kent Overstreet wrote: > > How about the following? > > There was no API to kmalloc bio and clone and osdblk was using > explicit bio_kmalloc() + __bio_clone(). (my guess here) As this is > inc

Re: [PATCH v5 10/12] block: Add bio_clone_kmalloc()

2012-08-08 Thread Tejun Heo
On Mon, Aug 06, 2012 at 03:08:39PM -0700, Kent Overstreet wrote: How about the following? There was no API to kmalloc bio and clone and osdblk was using explicit bio_kmalloc() + __bio_clone(). (my guess here) As this is inconvenient and there will be more users of it in the future, add bio_clone

[PATCH v5 10/12] block: Add bio_clone_kmalloc()

2012-08-06 Thread Kent Overstreet
Acked-by: Boaz Harrosh Signed-off-by: Kent Overstreet --- drivers/block/osdblk.c |3 +-- fs/bio.c | 13 + fs/exofs/ore.c |5 ++--- include/linux/bio.h|1 + 4 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/block/osdblk.c b