Re: [PATCH v5 1/6] qspinlock: powerpc support qspinlock

2016-06-21 Thread xinhui
On 2016年06月07日 05:41, Benjamin Herrenschmidt wrote: On Mon, 2016-06-06 at 17:59 +0200, Peter Zijlstra wrote: On Fri, Jun 03, 2016 at 02:33:47PM +1000, Benjamin Herrenschmidt wrote: - For the above, can you show (or describe) where the qspinlock improves things compared to our current l

Re: [PATCH v5 1/6] qspinlock: powerpc support qspinlock

2016-06-06 Thread Benjamin Herrenschmidt
On Mon, 2016-06-06 at 17:59 +0200, Peter Zijlstra wrote: > On Fri, Jun 03, 2016 at 02:33:47PM +1000, Benjamin Herrenschmidt wrote: > > > >  - For the above, can you show (or describe) where the qspinlock > >    improves things compared to our current locks. > So currently PPC has a fairly straight

Re: [PATCH v5 1/6] qspinlock: powerpc support qspinlock

2016-06-06 Thread Peter Zijlstra
On Fri, Jun 03, 2016 at 02:33:47PM +1000, Benjamin Herrenschmidt wrote: >  - For the above, can you show (or describe) where the qspinlock >    improves things compared to our current locks. So currently PPC has a fairly straight forward test-and-set spinlock IIRC. You have this because LPAR/virt

Re: [PATCH v5 1/6] qspinlock: powerpc support qspinlock

2016-06-03 Thread xinhui
On 2016年06月03日 12:33, Benjamin Herrenschmidt wrote: On Fri, 2016-06-03 at 12:10 +0800, xinhui wrote: On 2016年06月03日 09:32, Benjamin Herrenschmidt wrote: On Fri, 2016-06-03 at 11:32 +1000, Benjamin Herrenschmidt wrote: On Thu, 2016-06-02 at 17:22 +0800, Pan Xinhui wrote: Base code to enable

Re: [PATCH v5 1/6] qspinlock: powerpc support qspinlock

2016-06-02 Thread Benjamin Herrenschmidt
On Fri, 2016-06-03 at 12:10 +0800, xinhui wrote: > On 2016年06月03日 09:32, Benjamin Herrenschmidt wrote: > > On Fri, 2016-06-03 at 11:32 +1000, Benjamin Herrenschmidt wrote: > >> On Thu, 2016-06-02 at 17:22 +0800, Pan Xinhui wrote: > >>> > >>> Base code to enable qspinlock on powerpc. this patch add

Re: [PATCH v5 1/6] qspinlock: powerpc support qspinlock

2016-06-02 Thread xinhui
On 2016年06月03日 09:32, Benjamin Herrenschmidt wrote: On Fri, 2016-06-03 at 11:32 +1000, Benjamin Herrenschmidt wrote: On Thu, 2016-06-02 at 17:22 +0800, Pan Xinhui wrote: Base code to enable qspinlock on powerpc. this patch add some #ifdef here and there. Although there is no paravirt related

Re: [PATCH v5 1/6] qspinlock: powerpc support qspinlock

2016-06-02 Thread Benjamin Herrenschmidt
On Fri, 2016-06-03 at 11:32 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2016-06-02 at 17:22 +0800, Pan Xinhui wrote: > > > > Base code to enable qspinlock on powerpc. this patch add some > > #ifdef > > here and there. Although there is no paravirt related code, we can > > successfully build a q

Re: [PATCH v5 1/6] qspinlock: powerpc support qspinlock

2016-06-02 Thread Benjamin Herrenschmidt
On Thu, 2016-06-02 at 17:22 +0800, Pan Xinhui wrote: > Base code to enable qspinlock on powerpc. this patch add some #ifdef > here and there. Although there is no paravirt related code, we can > successfully build a qspinlock kernel after apply this patch. This is missing the IO_SYNC stuff ... It

[PATCH v5 1/6] qspinlock: powerpc support qspinlock

2016-06-02 Thread Pan Xinhui
Base code to enable qspinlock on powerpc. this patch add some #ifdef here and there. Although there is no paravirt related code, we can successfully build a qspinlock kernel after apply this patch. Signed-off-by: Pan Xinhui --- arch/powerpc/include/asm/qspinlock.h | 26 +

[PATCH v5 1/6] qspinlock: powerpc support qspinlock

2016-06-02 Thread Pan Xinhui
Base code to enable qspinlock on powerpc. this patch add some #ifdef here and there. Although there is no paravirt related code, we can successfully build a qspinlock kernel after apply this patch. Signed-off-by: Pan Xinhui --- arch/powerpc/include/asm/qspinlock.h | 26 +