Re: [PATCH v5 1/3] leds: pwm: Remove platform_data support

2020-09-30 Thread Alexander Dahl
Hello Pavel, On Wed, Sep 30, 2020 at 07:24:41PM +0200, Pavel Machek wrote: > Hi! > > > > > +__attribute__((nonnull)) > > > > > > > > static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, > > > > > > > >struct led_pwm *led, struct fwnode_handle > > > >

Re: [PATCH v5 1/3] leds: pwm: Remove platform_data support

2020-09-30 Thread Pavel Machek
Hi! > > > +__attribute__((nonnull)) > > > > > > static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, > > > > > > struct led_pwm *led, struct fwnode_handle *fwnode) > > > > > > { > > > > This normally goes elsewhere -- right? I'd expect: > > > > > > sta

Re: [PATCH v5 1/3] leds: pwm: Remove platform_data support

2020-09-28 Thread Alexander Dahl
Hello Pavel, Am Samstag, 19. September 2020, 11:44:18 CEST schrieb Pavel Machek: > > Since commit 141f15c66d94 ("leds: pwm: remove header") that platform > > interface is not usable from outside and there seems to be no in tree > > user anymore. All in-tree users of the leds-pwm driver seem to us

Re: [PATCH v5 1/3] leds: pwm: Remove platform_data support

2020-09-19 Thread Marek Behun
Besides Pavel's note about the __attribute__((nonnull)) position Reviewed-by: Marek BehĂșn

Re: [PATCH v5 1/3] leds: pwm: Remove platform_data support

2020-09-19 Thread Pavel Machek
Hi! > Since commit 141f15c66d94 ("leds: pwm: remove header") that platform > interface is not usable from outside and there seems to be no in tree > user anymore. All in-tree users of the leds-pwm driver seem to use DT > currently. Getting rid of the old platform interface will allow the > leds-

[PATCH v5 1/3] leds: pwm: Remove platform_data support

2020-09-18 Thread Alexander Dahl
Since commit 141f15c66d94 ("leds: pwm: remove header") that platform interface is not usable from outside and there seems to be no in tree user anymore. All in-tree users of the leds-pwm driver seem to use DT currently. Getting rid of the old platform interface will allow the leds-pwm driver to s