Re: [PATCH v5 1/2] mm: Allow the page cache to allocate large pages

2019-09-04 Thread Michal Hocko
On Tue 03-09-19 21:30:30, William Kucharski wrote: > > > > On Sep 3, 2019, at 5:57 AM, Michal Hocko wrote: > > > > On Mon 02-09-19 03:23:40, William Kucharski wrote: > >> Add an 'order' argument to __page_cache_alloc() and > >> do_read_cache_page(). Ensure the allocated pages are compound pages

Re: [PATCH v5 1/2] mm: Allow the page cache to allocate large pages

2019-09-03 Thread William Kucharski
> On Sep 3, 2019, at 5:57 AM, Michal Hocko wrote: > > On Mon 02-09-19 03:23:40, William Kucharski wrote: >> Add an 'order' argument to __page_cache_alloc() and >> do_read_cache_page(). Ensure the allocated pages are compound pages. > > Why do we need to touch all the existing callers and chan

Re: [PATCH v5 1/2] mm: Allow the page cache to allocate large pages

2019-09-03 Thread Michal Hocko
On Tue 03-09-19 09:28:31, Matthew Wilcox wrote: > On Tue, Sep 03, 2019 at 02:19:52PM +0200, Michal Hocko wrote: > > On Tue 03-09-19 05:11:55, Matthew Wilcox wrote: > > > On Tue, Sep 03, 2019 at 01:57:48PM +0200, Michal Hocko wrote: > > > > On Mon 02-09-19 03:23:40, William Kucharski wrote: > > > >

Re: [PATCH v5 1/2] mm: Allow the page cache to allocate large pages

2019-09-03 Thread Matthew Wilcox
On Tue, Sep 03, 2019 at 02:19:52PM +0200, Michal Hocko wrote: > On Tue 03-09-19 05:11:55, Matthew Wilcox wrote: > > On Tue, Sep 03, 2019 at 01:57:48PM +0200, Michal Hocko wrote: > > > On Mon 02-09-19 03:23:40, William Kucharski wrote: > > > > Add an 'order' argument to __page_cache_alloc() and > >

Re: [PATCH v5 1/2] mm: Allow the page cache to allocate large pages

2019-09-03 Thread Michal Hocko
On Tue 03-09-19 05:11:55, Matthew Wilcox wrote: > On Tue, Sep 03, 2019 at 01:57:48PM +0200, Michal Hocko wrote: > > On Mon 02-09-19 03:23:40, William Kucharski wrote: > > > Add an 'order' argument to __page_cache_alloc() and > > > do_read_cache_page(). Ensure the allocated pages are compound pages.

Re: [PATCH v5 1/2] mm: Allow the page cache to allocate large pages

2019-09-03 Thread Matthew Wilcox
On Tue, Sep 03, 2019 at 01:57:48PM +0200, Michal Hocko wrote: > On Mon 02-09-19 03:23:40, William Kucharski wrote: > > Add an 'order' argument to __page_cache_alloc() and > > do_read_cache_page(). Ensure the allocated pages are compound pages. > > Why do we need to touch all the existing callers a

Re: [PATCH v5 1/2] mm: Allow the page cache to allocate large pages

2019-09-03 Thread Michal Hocko
On Mon 02-09-19 03:23:40, William Kucharski wrote: > Add an 'order' argument to __page_cache_alloc() and > do_read_cache_page(). Ensure the allocated pages are compound pages. Why do we need to touch all the existing callers and change them to use order 0 when none is actually converted to a diffe

[PATCH v5 1/2] mm: Allow the page cache to allocate large pages

2019-09-02 Thread William Kucharski
Add an 'order' argument to __page_cache_alloc() and do_read_cache_page(). Ensure the allocated pages are compound pages. Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: William Kucharski Reported-by: kbuild test robot --- fs/afs/dir.c| 2 +- fs/btrfs/compression.c | 2 +-