Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data

2013-12-13 Thread Dave Young
On 12/12/13 at 10:04pm, Borislav Petkov wrote: > On Thu, Dec 12, 2013 at 03:17:43PM +0800, Dave Young wrote: > > Rethink about this issue, moving them to efi_$(BITS).c I need move the > > efi_setup from a static variable to an extern, It looks not worth. > > Dave, would you please do what is sugge

Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data

2013-12-12 Thread Borislav Petkov
On Thu, Dec 12, 2013 at 03:17:43PM +0800, Dave Young wrote: > Rethink about this issue, moving them to efi_$(BITS).c I need move the > efi_setup from a static variable to an extern, It looks not worth. Dave, would you please do what is suggested to you? A big part of the efi code is split into 32-

Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data

2013-12-11 Thread Dave Young
> > > > > > +void __init parse_efi_setup(u64 phys_addr) > > > +{ > > > + struct setup_data *sd; > > > + > > > + if (!efi_enabled(EFI_64BIT)) { > > > + pr_warn("SETUP_EFI not supported on 32-bit\n"); > > > + return; > > > + } > > > > Shouldn't this function be in two versions in e

Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data

2013-12-11 Thread Dave Young
> > > + */ > > > +static int __init map_regions_fixed(void) > > > +{ > > > + int i, s, ret = 0; > > > + u64 end, systab; > > > + unsigned long size; > > > + efi_memory_desc_t *md; > > > + struct efi_setup_data *data; > > > + > > > + s = sizeof(*data) + nr_efi_runtime_map * sizeof(data->map[0]); > >

Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data

2013-12-11 Thread Dave Young
On 12/11/13 at 11:20pm, Borislav Petkov wrote: > On Mon, Dec 09, 2013 at 05:42:22PM +0800, Dave Young wrote: > > Add a new setup_data type SETUP_EFI for kexec use. > > Passing the saved fw_vendor, runtime, config tables and efi runtime > > mappings. > > > > When entering virtual mode, directly ma

Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data

2013-12-11 Thread Dave Young
On 12/11/13 at 12:13pm, Matt Fleming wrote: > On Mon, 09 Dec, at 05:42:22PM, Dave Young wrote: > > Add a new setup_data type SETUP_EFI for kexec use. > > Passing the saved fw_vendor, runtime, config tables and efi runtime > > mappings. > > > > When entering virtual mode, directly mapping the efi

Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data

2013-12-11 Thread Dave Young
On 12/11/13 at 03:05pm, Borislav Petkov wrote: > On Wed, Dec 11, 2013 at 12:13:52PM +, Matt Fleming wrote: > > > + for (i = 0, md = data->map; i < nr_efi_runtime_map; i++, md++) { > > > + efi_map_region_fixed(md); /* FIXME: add error handling */ > > > > Oops. Please fix this ;-) > > Y

Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data

2013-12-11 Thread Borislav Petkov
On Mon, Dec 09, 2013 at 05:42:22PM +0800, Dave Young wrote: > Add a new setup_data type SETUP_EFI for kexec use. > Passing the saved fw_vendor, runtime, config tables and efi runtime mappings. > > When entering virtual mode, directly mapping the efi runtime ragions which > we passed in previously.

Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data

2013-12-11 Thread Borislav Petkov
On Wed, Dec 11, 2013 at 12:13:52PM +, Matt Fleming wrote: > > + for (i = 0, md = data->map; i < nr_efi_runtime_map; i++, md++) { > > + efi_map_region_fixed(md); /* FIXME: add error handling */ > > Oops. Please fix this ;-) Yeah, this is on my TODO as it wraps around __map_region,

Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data

2013-12-11 Thread Matt Fleming
On Mon, 09 Dec, at 05:42:22PM, Dave Young wrote: > Add a new setup_data type SETUP_EFI for kexec use. > Passing the saved fw_vendor, runtime, config tables and efi runtime mappings. > > When entering virtual mode, directly mapping the efi runtime ragions which > we passed in previously. And skip t

[PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data

2013-12-09 Thread Dave Young
Add a new setup_data type SETUP_EFI for kexec use. Passing the saved fw_vendor, runtime, config tables and efi runtime mappings. When entering virtual mode, directly mapping the efi runtime ragions which we passed in previously. And skip the step to call SetVirtualAddressMap. Specially for HP z42