Re: [PATCH v5 04/15] soundwire: Add MIPI DisCo property helpers

2017-12-11 Thread Vinod Koul
On Mon, Dec 11, 2017 at 06:06:30PM +0100, Takashi Iwai wrote: > On Mon, 11 Dec 2017 18:00:22 +0100, > Vinod Koul wrote: > > > > On Mon, Dec 11, 2017 at 05:10:17PM +0100, Takashi Iwai wrote: > > > On Wed, 06 Dec 2017 16:47:00 +0100, > > > Vinod Koul wrote: > > > > > > > > + /* TODO:

Re: [PATCH v5 04/15] soundwire: Add MIPI DisCo property helpers

2017-12-11 Thread Takashi Iwai
On Mon, 11 Dec 2017 18:00:22 +0100, Vinod Koul wrote: > > On Mon, Dec 11, 2017 at 05:10:17PM +0100, Takashi Iwai wrote: > > On Wed, 06 Dec 2017 16:47:00 +0100, > > Vinod Koul wrote: > > > > > > + /* TODO: Read audio mode */ > > > + > > > + i++; > > > + } > > > > Don't we use coun

Re: [PATCH v5 04/15] soundwire: Add MIPI DisCo property helpers

2017-12-11 Thread Vinod Koul
On Mon, Dec 11, 2017 at 05:10:17PM +0100, Takashi Iwai wrote: > On Wed, 06 Dec 2017 16:47:00 +0100, > Vinod Koul wrote: > > > > +static int sdw_slave_read_dpn(struct sdw_slave *slave, > > + struct sdw_dpn_prop *dpn, int count, int ports, char *type) > > +{ > > > + nval = f

Re: [PATCH v5 04/15] soundwire: Add MIPI DisCo property helpers

2017-12-11 Thread Takashi Iwai
On Wed, 06 Dec 2017 16:47:00 +0100, Vinod Koul wrote: > > +static int sdw_slave_read_dpn(struct sdw_slave *slave, > + struct sdw_dpn_prop *dpn, int count, int ports, char *type) > +{ > + nval = fwnode_property_read_u32_array(node, > + "mipi-

[PATCH v5 04/15] soundwire: Add MIPI DisCo property helpers

2017-12-06 Thread Vinod Koul
MIPI Discovery And Configuration (DisCo) Specification for SoundWire specifies properties to be implemented for SoundWire Masters and Slaves. The DisCo spec doesn't mandate these properties. However, SDW bus cannot work without knowing these values. The helper functions read the Master and Slave p