Re: [PATCH v5 03/18] crypto: sun8i-ss: support hash algorithms

2020-08-27 Thread Herbert Xu
On Fri, Aug 21, 2020 at 01:43:20PM +, Corentin Labbe wrote: > > + err = pm_runtime_get_sync(op->ss->dev); > + if (err < 0) > + goto error_pm; > + return 0; You need to handle the error case like this: https://patchwork.kernel.org/patch/11728595/ Cheers, -- Email: Her

[PATCH v5 03/18] crypto: sun8i-ss: support hash algorithms

2020-08-21 Thread Corentin Labbe
The SS support multiples hash algorithms, this patch adds support for MD5, SHA1, SHA224 and SHA256. Signed-off-by: Corentin Labbe --- drivers/crypto/allwinner/Kconfig | 9 + drivers/crypto/allwinner/sun8i-ss/Makefile| 1 + .../crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 155