Re: [PATCH v5 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-08-15 Thread Kent Overstreet
On Tue, Aug 14, 2012 at 02:33:20PM +0900, Jun'ichi Nomura wrote: > On 08/07/12 07:08, Kent Overstreet wrote: > > struct dm_rq_clone_bio_info { > > struct bio *orig; > > struct dm_rq_target_io *tio; > > + struct bio clone; > > }; > ... > > - pools->bs = bioset_create(pool_size, 0); > >

Re: [PATCH v5 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-08-13 Thread Jun'ichi Nomura
On 08/07/12 07:08, Kent Overstreet wrote: > struct dm_rq_clone_bio_info { > struct bio *orig; > struct dm_rq_target_io *tio; > + struct bio clone; > }; ... > - pools->bs = bioset_create(pool_size, 0); > + pools->bs = bioset_create(pool_size, > +

Re: [PATCH v5 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-08-13 Thread Kent Overstreet
On Sat, Aug 11, 2012 at 03:24:45PM +1000, Joseph Glanville wrote: > Hi Kent, Tejun > > On 9 August 2012 09:57, Kent Overstreet wrote: > >> Also, how was this tested? > > > > Well, AFAICT the only request based dm target is multipath, and from the > > documentation I've seen it doesn't appear to w

Re: [PATCH v5 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-08-10 Thread Joseph Glanville
Hi Kent, Tejun On 9 August 2012 09:57, Kent Overstreet wrote: >> Also, how was this tested? > > Well, AFAICT the only request based dm target is multipath, and from the > documentation I've seen it doesn't appear to work without multipath > hardware, or at least I haven't seen it documented how.

Re: [PATCH v5 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-08-08 Thread Kent Overstreet
On Wed, Aug 08, 2012 at 03:06:12PM -0700, Tejun Heo wrote: > Hello, > > On Mon, Aug 06, 2012 at 03:08:31PM -0700, Kent Overstreet wrote: > > Previously, dm_rq_clone_bio_info needed to be freed by the bio's > > destructor to avoid a memory leak in the blk_rq_prep_clone() error path. > > This gets r

Re: [PATCH v5 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-08-08 Thread Tejun Heo
Hello, On Mon, Aug 06, 2012 at 03:08:31PM -0700, Kent Overstreet wrote: > Previously, dm_rq_clone_bio_info needed to be freed by the bio's > destructor to avoid a memory leak in the blk_rq_prep_clone() error path. > This gets rid of a memory allocation and means we can kill > dm_rq_bio_destructor.

[PATCH v5 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-08-06 Thread Kent Overstreet
Previously, dm_rq_clone_bio_info needed to be freed by the bio's destructor to avoid a memory leak in the blk_rq_prep_clone() error path. This gets rid of a memory allocation and means we can kill dm_rq_bio_destructor. Signed-off-by: Kent Overstreet --- drivers/md/dm.c | 31 +--