Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-19 Thread Sami Tolvanen
Hi Darrick, On Tue, Nov 19, 2024 at 12:48 PM Darrick J. Wong wrote: > > On Mon, Nov 18, 2024 at 09:58:09PM +, Sami Tolvanen wrote: > > Hi, > > > > On Sat, Nov 16, 2024 at 9:09 AM Masahiro Yamada > > wrote: > > > > > > On Thu, Nov 14, 2024 at 2:54 AM Sami Tolvanen > > > wrote: > > > > > >

Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-19 Thread Darrick J. Wong
On Mon, Nov 18, 2024 at 09:58:09PM +, Sami Tolvanen wrote: > Hi, > > On Sat, Nov 16, 2024 at 9:09 AM Masahiro Yamada wrote: > > > > On Thu, Nov 14, 2024 at 2:54 AM Sami Tolvanen > > wrote: > > > > > > Hi, > > > > > > On Mon, Nov 11, 2024 at 8:06 PM Masahiro Yamada > > > wrote: > > > > > >

Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-18 Thread Sami Tolvanen
Hi, On Sat, Nov 16, 2024 at 9:09 AM Masahiro Yamada wrote: > > On Thu, Nov 14, 2024 at 2:54 AM Sami Tolvanen wrote: > > > > Hi, > > > > On Mon, Nov 11, 2024 at 8:06 PM Masahiro Yamada > > wrote: > > > > > > On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen > > > wrote: > > > > > > > > To avoid d

Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-16 Thread Masahiro Yamada
On Thu, Nov 14, 2024 at 2:54 AM Sami Tolvanen wrote: > > Hi, > > On Mon, Nov 11, 2024 at 8:06 PM Masahiro Yamada wrote: > > > > On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen > > wrote: > > > > > > To avoid duplication between host programs, move the crc32 code to a > > > shared header file. > >

Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-13 Thread Neal Gompa
On Wed, Nov 13, 2024 at 2:35 PM Luis Chamberlain wrote: > > On Wed, Nov 13, 2024 at 09:04:51AM -0500, Neal Gompa wrote: > > On Mon, Nov 11, 2024 at 11:06 PM Masahiro Yamada > > wrote: > > > > > > On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen > > > wrote: > > > > > > > > Suggested-by: Petr Pavl

Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-13 Thread Luis Chamberlain
On Wed, Nov 13, 2024 at 09:04:51AM -0500, Neal Gompa wrote: > On Mon, Nov 11, 2024 at 11:06 PM Masahiro Yamada wrote: > > > > On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen > > wrote: > > > > > > Suggested-by: Petr Pavlu > > > Signed-off-by: Sami Tolvanen > > > Acked-by: Neal Gompa > > > > Doe

Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-13 Thread Sami Tolvanen
Hi, On Mon, Nov 11, 2024 at 8:06 PM Masahiro Yamada wrote: > > On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen wrote: > > > > To avoid duplication between host programs, move the crc32 code to a > > shared header file. > > > Only the motivation to use this long table is to keep compatibility > bet

Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-13 Thread Neal Gompa
On Mon, Nov 11, 2024 at 11:06 PM Masahiro Yamada wrote: > > On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen wrote: > > > > Suggested-by: Petr Pavlu > > Signed-off-by: Sami Tolvanen > > Acked-by: Neal Gompa > > Does this Ack add any value? > > Acked-by is meaningful only when it is given by someo

Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-11 Thread Masahiro Yamada
On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen wrote: > > To avoid duplication between host programs, move the crc32 code to a > shared header file. Only the motivation to use this long table is to keep compatibility between genksyms and gendwarfksyms. I do not think this should be exposed to oth

[PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-10-30 Thread Sami Tolvanen
To avoid duplication between host programs, move the crc32 code to a shared header file. Suggested-by: Petr Pavlu Signed-off-by: Sami Tolvanen Acked-by: Neal Gompa --- scripts/genksyms/genksyms.c | 77 +- scripts/include/crc32.h | 93