Re: [PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-24 Thread Paraschiv, Andra-Irina
On 24/07/2020 02:04, Alexander Graf wrote: On 23.07.20 20:21, Paraschiv, Andra-Irina wrote: On 23/07/2020 13:54, Greg KH wrote: On Thu, Jul 23, 2020 at 12:23:56PM +0300, Paraschiv, Andra-Irina wrote: On 22/07/2020 12:57, Greg KH wrote: On Wed, Jul 22, 2020 at 11:27:29AM +0300, Paraschiv

Re: [PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-23 Thread Alexander Graf
On 23.07.20 20:21, Paraschiv, Andra-Irina wrote: On 23/07/2020 13:54, Greg KH wrote: On Thu, Jul 23, 2020 at 12:23:56PM +0300, Paraschiv, Andra-Irina wrote: On 22/07/2020 12:57, Greg KH wrote: On Wed, Jul 22, 2020 at 11:27:29AM +0300, Paraschiv, Andra-Irina wrote: +#ifndef _UAPI_LINUX_NI

Re: [PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-23 Thread Paraschiv, Andra-Irina
On 23/07/2020 13:54, Greg KH wrote: On Thu, Jul 23, 2020 at 12:23:56PM +0300, Paraschiv, Andra-Irina wrote: On 22/07/2020 12:57, Greg KH wrote: On Wed, Jul 22, 2020 at 11:27:29AM +0300, Paraschiv, Andra-Irina wrote: +#ifndef _UAPI_LINUX_NITRO_ENCLAVES_H_ +#define _UAPI_LINUX_NITRO_ENCLAVES_

Re: [PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-23 Thread Greg KH
On Thu, Jul 23, 2020 at 12:23:56PM +0300, Paraschiv, Andra-Irina wrote: > > > On 22/07/2020 12:57, Greg KH wrote: > > On Wed, Jul 22, 2020 at 11:27:29AM +0300, Paraschiv, Andra-Irina wrote: > > > > > +#ifndef _UAPI_LINUX_NITRO_ENCLAVES_H_ > > > > > +#define _UAPI_LINUX_NITRO_ENCLAVES_H_ > > > > >

Re: [PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-23 Thread Paraschiv, Andra-Irina
On 22/07/2020 12:57, Greg KH wrote: On Wed, Jul 22, 2020 at 11:27:29AM +0300, Paraschiv, Andra-Irina wrote: +#ifndef _UAPI_LINUX_NITRO_ENCLAVES_H_ +#define _UAPI_LINUX_NITRO_ENCLAVES_H_ + +#include + +/* Nitro Enclaves (NE) Kernel Driver Interface */ + +#define NE_API_VERSION (1) Why do you

Re: [PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-22 Thread Greg KH
On Wed, Jul 22, 2020 at 11:27:29AM +0300, Paraschiv, Andra-Irina wrote: > > > +#ifndef _UAPI_LINUX_NITRO_ENCLAVES_H_ > > > +#define _UAPI_LINUX_NITRO_ENCLAVES_H_ > > > + > > > +#include > > > + > > > +/* Nitro Enclaves (NE) Kernel Driver Interface */ > > > + > > > +#define NE_API_VERSION (1) > > W

Re: [PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-22 Thread Paraschiv, Andra-Irina
On 21/07/2020 15:12, Greg KH wrote: On Wed, Jul 15, 2020 at 10:45:23PM +0300, Andra Paraschiv wrote: The Nitro Enclaves driver handles the enclave lifetime management. This includes enclave creation, termination and setting up its resources such as memory and CPU. An enclave runs alongside th

Re: [PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-21 Thread Greg KH
On Wed, Jul 15, 2020 at 10:45:23PM +0300, Andra Paraschiv wrote: > The Nitro Enclaves driver handles the enclave lifetime management. This > includes enclave creation, termination and setting up its resources such > as memory and CPU. > > An enclave runs alongside the VM that spawned it. It is abs

Re: [PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-16 Thread Paraschiv, Andra-Irina
On 16/07/2020 11:30, Stefan Hajnoczi wrote: On Wed, Jul 15, 2020 at 10:45:23PM +0300, Andra Paraschiv wrote: + * A NE CPU pool has be set before calling this function. The pool can be set s/has be/has to be/ Fixed. Thanks, this looks good! Reviewed-by: Stefan Hajnoczi Thanks for rev

Re: [PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-16 Thread Stefan Hajnoczi
On Wed, Jul 15, 2020 at 10:45:23PM +0300, Andra Paraschiv wrote: > + * A NE CPU pool has be set before calling this function. The pool can be set s/has be/has to be/ Thanks, this looks good! Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-15 Thread Andra Paraschiv
The Nitro Enclaves driver handles the enclave lifetime management. This includes enclave creation, termination and setting up its resources such as memory and CPU. An enclave runs alongside the VM that spawned it. It is abstracted as a process running in the VM that launched it. The process intera