Re: [PATCH v5 01/14] x86/mm: sparse warning fix for early_memremap

2013-12-11 Thread Dave Young
On 12/11/13 at 12:12pm, Borislav Petkov wrote: > On Wed, Dec 11, 2013 at 10:20:25AM +, Matt Fleming wrote: > > This needs reviewing by at least one of the x86 folks, but it > > certainly makes sense to me. > > Ingo told me yesterday, it makes sense too. I'd guess we can try it. > FWIW, all cal

Re: [PATCH v5 01/14] x86/mm: sparse warning fix for early_memremap

2013-12-11 Thread Borislav Petkov
On Wed, Dec 11, 2013 at 10:20:25AM +, Matt Fleming wrote: > This needs reviewing by at least one of the x86 folks, but it > certainly makes sense to me. Ingo told me yesterday, it makes sense too. I'd guess we can try it. FWIW, all callers of early_memremap use the memory they get remapped as

Re: [PATCH v5 01/14] x86/mm: sparse warning fix for early_memremap

2013-12-11 Thread Matt Fleming
On Tue, 10 Dec, at 10:12:21AM, Dave Young wrote: > On 12/09/13 at 04:05pm, Borislav Petkov wrote: > > On Mon, Dec 09, 2013 at 05:42:14PM +0800, Dave Young wrote: > > > There's a lot of sparse warnings for code like below: > > > void *a = early_memremap(phys_addr, size); > > > > > > early_memremap

Re: [PATCH v5 01/14] x86/mm: sparse warning fix for early_memremap

2013-12-09 Thread Dave Young
On 12/09/13 at 04:05pm, Borislav Petkov wrote: > On Mon, Dec 09, 2013 at 05:42:14PM +0800, Dave Young wrote: > > There's a lot of sparse warnings for code like below: > > void *a = early_memremap(phys_addr, size); > > > > early_memremap intend to map kernel memory with ioremap facility, the return

Re: [PATCH v5 01/14] x86/mm: sparse warning fix for early_memremap

2013-12-09 Thread Borislav Petkov
On Mon, Dec 09, 2013 at 05:42:14PM +0800, Dave Young wrote: > There's a lot of sparse warnings for code like below: > void *a = early_memremap(phys_addr, size); > > early_memremap intend to map kernel memory with ioremap facility, the return > pointer should be a kernel ram pointer instead of iome

[PATCH v5 01/14] x86/mm: sparse warning fix for early_memremap

2013-12-09 Thread Dave Young
There's a lot of sparse warnings for code like below: void *a = early_memremap(phys_addr, size); early_memremap intend to map kernel memory with ioremap facility, the return pointer should be a kernel ram pointer instead of iomem one. For making the function clearer and supressing sparse warnings