Re: [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros

2015-06-11 Thread Josh Poimboeuf
On Thu, Jun 11, 2015 at 08:46:33AM +0200, Pavel Machek wrote: > On Thu 2015-06-11 06:22:49, Jiri Kosina wrote: > > On Wed, 10 Jun 2015, Pavel Machek wrote: > > > > > > diff --git a/arch/x86/include/asm/func.h b/arch/x86/include/asm/func.h > > > > new file mode 100644 > > > > index 000..4d62782

Re: [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros

2015-06-11 Thread Jiri Kosina
On Thu, 11 Jun 2015, Pavel Machek wrote: > > We have quite a few of .h headers in the kernel already which are supposed > > to be included only by .S files, so what exactly is the problem you are > > seeing here? > > Such as...? arch/x86/include/asm/calling.h is seems to be the only one (on

Re: [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros

2015-06-10 Thread Pavel Machek
On Thu 2015-06-11 06:22:49, Jiri Kosina wrote: > On Wed, 10 Jun 2015, Pavel Machek wrote: > > > > diff --git a/arch/x86/include/asm/func.h b/arch/x86/include/asm/func.h > > > new file mode 100644 > > > index 000..4d62782 > > > --- /dev/null > > > +++ b/arch/x86/include/asm/func.h > > > @@ -0,0

Re: [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros

2015-06-10 Thread Jiri Kosina
On Wed, 10 Jun 2015, Pavel Machek wrote: > > diff --git a/arch/x86/include/asm/func.h b/arch/x86/include/asm/func.h > > new file mode 100644 > > index 000..4d62782 > > --- /dev/null > > +++ b/arch/x86/include/asm/func.h > > @@ -0,0 +1,24 @@ > > +#ifndef _ASM_X86_FUNC_H > > +#define _ASM_X86_FU

Re: [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros

2015-06-10 Thread Josh Poimboeuf
On Wed, Jun 10, 2015 at 08:17:32PM +0200, Pavel Machek wrote: > On Wed 2015-06-10 07:06:09, Josh Poimboeuf wrote: > > Add the FP_SAVE and FP_RESTORE asm macros, which can be used to save and > > restore the frame pointer. > > Add a changelog, which can be used to tell what changed. Fair enough :-

Re: [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros

2015-06-10 Thread Pavel Machek
On Wed 2015-06-10 07:06:09, Josh Poimboeuf wrote: > Add the FP_SAVE and FP_RESTORE asm macros, which can be used to save and > restore the frame pointer. Add a changelog, which can be used to tell what changed. > Signed-off-by: Josh Poimboeuf > --- > arch/x86/include/asm/func.h | 24 +++

[PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros

2015-06-10 Thread Josh Poimboeuf
Add the FP_SAVE and FP_RESTORE asm macros, which can be used to save and restore the frame pointer. Signed-off-by: Josh Poimboeuf --- arch/x86/include/asm/func.h | 24 1 file changed, 24 insertions(+) create mode 100644 arch/x86/include/asm/func.h diff --git a/arch/x86