Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

2014-02-07 Thread Frank Rowand
On 2/7/2014 12:51 PM, Joe Perches wrote: > On Fri, 2014-02-07 at 11:38 -0800, Frank Rowand wrote: >> On 2/6/2014 9:11 PM, Joe Perches wrote: >>> For patch 1, what checkpatch bug might that be? > [] >> Sorry, it is patch 2, not patch 1 ("[PATCH v5 02/14] clk: Add >> set_rate_and_parent() op"): >> >

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

2014-02-07 Thread Joe Perches
On Fri, 2014-02-07 at 11:38 -0800, Frank Rowand wrote: > On 2/6/2014 9:11 PM, Joe Perches wrote: > > For patch 1, what checkpatch bug might that be? [] > Sorry, it is patch 2, not patch 1 ("[PATCH v5 02/14] clk: Add > set_rate_and_parent() op"): > >WARNING: Multiple spaces after return type >

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

2014-02-07 Thread Frank Rowand
On 2/6/2014 9:11 PM, Joe Perches wrote: > On Thu, 2014-02-06 at 20:15 -0800, Frank Rowand wrote: >> On 1/15/2014 10:47 AM, Stephen Boyd wrote: >>> The first breaks a reset-controller include ordering requirement. It got >>> an ack so I think we're ok for it to go through the clock tree. >>> >> >> <

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

2014-02-06 Thread Joe Perches
On Thu, 2014-02-06 at 20:15 -0800, Frank Rowand wrote: > On 1/15/2014 10:47 AM, Stephen Boyd wrote: > > The first breaks a reset-controller include ordering requirement. It got > > an ack so I think we're ok for it to go through the clock tree. > > > > < snip > > > checkpatch is whining about pa

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

2014-02-06 Thread Frank Rowand
On 2/6/2014 8:15 PM, Frank Rowand wrote: > On 1/15/2014 10:47 AM, Stephen Boyd wrote: >> The first breaks a reset-controller include ordering requirement. It got >> an ack so I think we're ok for it to go through the clock tree. >> > > < snip > > > checkpatch is whining about patches > < snip >

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

2014-02-06 Thread Frank Rowand
On 1/15/2014 10:47 AM, Stephen Boyd wrote: > The first breaks a reset-controller include ordering requirement. It got > an ack so I think we're ok for it to go through the clock tree. > < snip > checkpatch is whining about patches 4 5 6 7 8 (Just for completeness if someone thinks I

[PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

2014-01-15 Thread Stephen Boyd
The first breaks a reset-controller include ordering requirement. It got an ack so I think we're ok for it to go through the clock tree. The next patch adds support for setting the rate and the parent at the same time based on patches from James Hogan's remuxing set_rate series. After that we add