Re: [PATCH v5] serial/arc-uart: Add new driver

2012-10-29 Thread Vineet Gupta
I've already posted a v7 of the driver - with all your comments. If you think it's ok - can you ACK it please ! TIA, -Vineet On Monday 29 October 2012 04:36 PM, Felipe Balbi wrote: > On Sat, Oct 27, 2012 at 12:24:46PM +0530, Vineet Gupta wrote: >> On Friday 26 October 2012 05:40 PM, Felipe Balbi

Re: [PATCH v5] serial/arc-uart: Add new driver

2012-10-29 Thread Felipe Balbi
On Sat, Oct 27, 2012 at 12:24:46PM +0530, Vineet Gupta wrote: > On Friday 26 October 2012 05:40 PM, Felipe Balbi wrote: > > On Fri, Oct 26, 2012 at 05:33:16PM +0530, vineet.gup...@synopsys.com wrote: > >> +/* > >> + * Release the memory region(s) being used by 'port'. > >> + */ > >> +static void ar

Re: [PATCH v5] serial/arc-uart: Add new driver

2012-10-26 Thread Vineet Gupta
On Friday 26 October 2012 05:40 PM, Felipe Balbi wrote: > On Fri, Oct 26, 2012 at 05:33:16PM +0530, vineet.gup...@synopsys.com wrote: >> +/* >> + * Release the memory region(s) being used by 'port'. >> + */ >> +static void arc_serial_release_port(struct uart_port *port) >> +{ >> +} >> + >> +/* >> +

Re: [PATCH v5] serial/arc-uart: Add new driver

2012-10-26 Thread Felipe Balbi
hi, On Fri, Oct 26, 2012 at 06:17:26PM +0530, Vineet Gupta wrote: > >> +#endif > >> +}; > >> + > >> +static void arc_serial_stop_rx(struct uart_port *port) > >> +{ > >> + struct arc_uart_port *uart = (struct arc_uart_port *)port; > > I would suggest using container_of() here. It's very unlikely t

Re: [PATCH v5] serial/arc-uart: Add new driver

2012-10-26 Thread Vineet Gupta
On Friday 26 October 2012 05:40 PM, Felipe Balbi wrote: > On Fri, Oct 26, 2012 at 05:33:16PM +0530, vineet.gup...@synopsys.com wrote: >> From: Vineet Gupta >> >> Driver for non-standard on-chip UART, instantiated in the ARC (Synopsys) >> FPGA Boards such as ARCAngel4/ML50x >> >> Signed-off-by: Vin

Re: [PATCH v5] serial/arc-uart: Add new driver

2012-10-26 Thread Felipe Balbi
On Fri, Oct 26, 2012 at 05:33:16PM +0530, vineet.gup...@synopsys.com wrote: > From: Vineet Gupta > > Driver for non-standard on-chip UART, instantiated in the ARC (Synopsys) > FPGA Boards such as ARCAngel4/ML50x > > Signed-off-by: Vineet Gupta > --- > drivers/tty/serial/Kconfig | 23 ++

[PATCH v5] serial/arc-uart: Add new driver

2012-10-26 Thread Vineet.Gupta1
From: Vineet Gupta Hi Greg, Here's the updated revision with fixes per your review comments. -Rebased off tty-next tip. -Build tested for x86, both as builtin and as module -Same driver (as module) verified on ARCAngel4 Board. Please consider applying. Thanks, Vineet v5: * Driver now builds a

[PATCH v5] serial/arc-uart: Add new driver

2012-10-26 Thread Vineet.Gupta1
From: Vineet Gupta Driver for non-standard on-chip UART, instantiated in the ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x Signed-off-by: Vineet Gupta --- drivers/tty/serial/Kconfig | 23 ++ drivers/tty/serial/Makefile |1 + drivers/tty/serial/arc_uart.c| 754 +++