Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2015-01-05 Thread Wanpeng Li
Hi Peter, On Mon, Jan 05, 2015 at 03:52:10PM +0100, Peter Zijlstra wrote: >On Wed, Nov 12, 2014 at 04:39:06PM +0100, Peter Zijlstra wrote: >> On Wed, Nov 12, 2014 at 03:08:44PM +, Juri Lelli wrote: >> > > @@ -1185,8 +1223,9 @@ static int find_later_rq(struct task_struct *task) >> > >

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2015-01-05 Thread Peter Zijlstra
On Wed, Nov 12, 2014 at 04:39:06PM +0100, Peter Zijlstra wrote: > On Wed, Nov 12, 2014 at 03:08:44PM +, Juri Lelli wrote: > > > @@ -1185,8 +1223,9 @@ static int find_later_rq(struct task_struct *task) > > >* We have to consider system topology and task affinity > > >* first, then we can

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-20 Thread Wanpeng Li
Hi Peterz, Juri, On Thu, Nov 13, 2014 at 01:21:31PM +0300, Kirill Tkhai wrote: >> > Also, we should think about the following situation. >> > >> > DL task is left on dead rq. In your scheme it will be moved by the timer. >> > But what will be if somebody changes the class of the task (before timer)

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-19 Thread Wanpeng Li
Hi Juri, On Wed, Nov 19, 2014 at 01:49:20PM +, Juri Lelli wrote: [...] >> @@ -1185,8 +1223,9 @@ static int find_later_rq(struct task_struct *task) >> * We have to consider system topology and task affinity >> * first, then we can look for a suitable cpu. >>

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-19 Thread Juri Lelli
Hi, On 19/11/14 12:30, Wanpeng Li wrote: > Hi Juri, > On 11/19/14, 6:13 PM, Juri Lelli wrote: >> Hi, >> >> On 18/11/14 23:18, Wanpeng Li wrote: >>> Hi Juri, >>> On 11/12/14, 11:08 PM, Juri Lelli wrote: Hi, On 12/11/14 01:06, Wanpeng Li wrote: > I observe that dl task can't be mi

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-19 Thread Wanpeng Li
Hi Juri, On 11/19/14, 6:13 PM, Juri Lelli wrote: Hi, On 18/11/14 23:18, Wanpeng Li wrote: Hi Juri, On 11/12/14, 11:08 PM, Juri Lelli wrote: Hi, On 12/11/14 01:06, Wanpeng Li wrote: I observe that dl task can't be migrated to other cpus during cpu hotplug, in addition, task may/may not be run

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-19 Thread Juri Lelli
Hi, On 18/11/14 23:18, Wanpeng Li wrote: > Hi Juri, > On 11/12/14, 11:08 PM, Juri Lelli wrote: >> Hi, >> >> On 12/11/14 01:06, Wanpeng Li wrote: >>> I observe that dl task can't be migrated to other cpus during cpu hotplug, >>> in addition, task may/may not be running again if cpu is added back. T

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-18 Thread Wanpeng Li
Hi Juri, On 11/12/14, 11:08 PM, Juri Lelli wrote: Hi, On 12/11/14 01:06, Wanpeng Li wrote: I observe that dl task can't be migrated to other cpus during cpu hotplug, in addition, task may/may not be running again if cpu is added back. The root cause which I found is that dl task will be throtte

Re:[PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-17 Thread Kirill Tkhai
> Hi Kirill, > On Thu, Nov 13, 2014 at 01:21:31PM +0300, Kirill Tkhai wrote: > >>> @@ -1185,8 +1223,9 @@ static int find_later_rq(struct task_struct *task) >>> * We have to consider system topology and task affinity >>> * first, then we can look for a suitable cpu. >>> */ >>>

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-16 Thread Wanpeng Li
Hi Kirill, On Thu, Nov 13, 2014 at 01:21:31PM +0300, Kirill Tkhai wrote: >> @@ -1185,8 +1223,9 @@ static int find_later_rq(struct task_struct *task) >> * We have to consider system topology and task affinity >> * first, then we can look for a suitable cpu. >>

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-13 Thread Kirill Tkhai
В Чт, 13/11/2014 в 18:19 +0800, Wanpeng Li пишет: > Hi Kirill, > On 11/13/14, 6:10 PM, Kirill Tkhai wrote: > > В Чт, 13/11/2014 в 06:56 +0800, Wanpeng Li пишет: > >> Hi Kirill, > >> On Wed, Nov 12, 2014 at 07:27:06PM +0300, Kirill Tkhai wrote: > >>> В Ср, 12/11/2014 в 09:06 +0800, Wanpeng Li пишет:

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-13 Thread Wanpeng Li
Hi Kirill, On 11/13/14, 6:10 PM, Kirill Tkhai wrote: В Чт, 13/11/2014 в 06:56 +0800, Wanpeng Li пишет: Hi Kirill, On Wed, Nov 12, 2014 at 07:27:06PM +0300, Kirill Tkhai wrote: В Ср, 12/11/2014 в 09:06 +0800, Wanpeng Li пишет: I observe that dl task can't be migrated to other cpus during cpu ho

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-13 Thread Kirill Tkhai
В Чт, 13/11/2014 в 06:56 +0800, Wanpeng Li пишет: > Hi Kirill, > On Wed, Nov 12, 2014 at 07:27:06PM +0300, Kirill Tkhai wrote: > >В Ср, 12/11/2014 в 09:06 +0800, Wanpeng Li пишет: > >> I observe that dl task can't be migrated to other cpus during cpu hotplug, > >> in addition, task may/may not be

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-12 Thread Wanpeng Li
Hi Juri, On Wed, Nov 12, 2014 at 03:08:44PM +, Juri Lelli wrote: Btw, could you review other three deadline patches of mine? https://lkml.org/lkml/2014/11/6/51 https://lkml.org/lkml/2014/11/10/817 https://lkml.org/lkml/2014/11/10/818 Great thanks for your time. ;-) Regards, Wanpeng Li >Hi

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-12 Thread Wanpeng Li
Hi Peter, On Wed, Nov 12, 2014 at 04:39:06PM +0100, Peter Zijlstra wrote: >On Wed, Nov 12, 2014 at 03:08:44PM +, Juri Lelli wrote: >> > @@ -1185,8 +1223,9 @@ static int find_later_rq(struct task_struct *task) >> > * We have to consider system topology and task affinity >> > * first, the

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-12 Thread Wanpeng Li
Hi Kirill, On Wed, Nov 12, 2014 at 07:27:06PM +0300, Kirill Tkhai wrote: >В Ср, 12/11/2014 в 09:06 +0800, Wanpeng Li пишет: >> I observe that dl task can't be migrated to other cpus during cpu hotplug, >> in addition, task may/may not be running again if cpu is added back. The >> root cause which

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-12 Thread Kirill Tkhai
В Ср, 12/11/2014 в 09:06 +0800, Wanpeng Li пишет: > I observe that dl task can't be migrated to other cpus during cpu hotplug, > in addition, task may/may not be running again if cpu is added back. The > root cause which I found is that dl task will be throtted and removed from > dl rq after com

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-12 Thread Peter Zijlstra
On Wed, Nov 12, 2014 at 03:08:44PM +, Juri Lelli wrote: > > @@ -1185,8 +1223,9 @@ static int find_later_rq(struct task_struct *task) > > * We have to consider system topology and task affinity > > * first, then we can look for a suitable cpu. > > */ > > - cpumask_copy(later_mas

Re: [PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-12 Thread Juri Lelli
Hi, On 12/11/14 01:06, Wanpeng Li wrote: > I observe that dl task can't be migrated to other cpus during cpu hotplug, > in addition, task may/may not be running again if cpu is added back. The > root cause which I found is that dl task will be throtted and removed from > dl rq after comsuming a

[PATCH v5] sched/deadline: support dl task migration during cpu hotplug

2014-11-11 Thread Wanpeng Li
I observe that dl task can't be migrated to other cpus during cpu hotplug, in addition, task may/may not be running again if cpu is added back. The root cause which I found is that dl task will be throtted and removed from dl rq after comsuming all budget, which leads to stop task can't pick it