Re: [PATCH v5] sched/deadline: remove useless param from setup_new_dl_entity

2016-08-05 Thread Juri Lelli
On 05/08/16 10:54, Steven Rostedt wrote: > On Fri, 5 Aug 2016 15:34:44 +0100 > Juri Lelli wrote: > > > On 05/08/16 09:56, Steven Rostedt wrote: > > > On Fri, 5 Aug 2016 11:09:59 +0100 > > > Juri Lelli wrote: > > > > > > > @@ -1720,19 +1720,28 @@ static void switched_from_dl(struct rq *rq, >

Re: [PATCH v5] sched/deadline: remove useless param from setup_new_dl_entity

2016-08-05 Thread Steven Rostedt
On Fri, 5 Aug 2016 15:34:44 +0100 Juri Lelli wrote: > On 05/08/16 09:56, Steven Rostedt wrote: > > On Fri, 5 Aug 2016 11:09:59 +0100 > > Juri Lelli wrote: > > > > > @@ -1720,19 +1720,28 @@ static void switched_from_dl(struct rq *rq, > > > struct task_struct *p) > > > */ > > > static void

Re: [PATCH v5] sched/deadline: remove useless param from setup_new_dl_entity

2016-08-05 Thread Juri Lelli
On 05/08/16 09:56, Steven Rostedt wrote: > On Fri, 5 Aug 2016 11:09:59 +0100 > Juri Lelli wrote: > > > @@ -1720,19 +1720,28 @@ static void switched_from_dl(struct rq *rq, struct > > task_struct *p) > > */ > > static void switched_to_dl(struct rq *rq, struct task_struct *p) > > { > > - if

Re: [PATCH v5] sched/deadline: remove useless param from setup_new_dl_entity

2016-08-05 Thread Steven Rostedt
On Fri, 5 Aug 2016 11:09:59 +0100 Juri Lelli wrote: > @@ -1720,19 +1720,28 @@ static void switched_from_dl(struct rq *rq, struct > task_struct *p) > */ > static void switched_to_dl(struct rq *rq, struct task_struct *p) > { > - if (dl_time_before(p->dl.deadline, rq_clock(rq))) > -

Re: [PATCH v5] sched/deadline: remove useless param from setup_new_dl_entity

2016-08-05 Thread Xunlei Pang
On 2016/08/05 at 18:09, Juri Lelli wrote: > setup_new_dl_entity() takes two parameters, but it only actually uses > one of them, under a different name, to setup a new dl_entity, after: > > 2f9f3fdc928 "sched/deadline: Remove dl_new from struct sched_dl_entity" > > as we currently do > > setup_ne

[PATCH v5] sched/deadline: remove useless param from setup_new_dl_entity

2016-08-05 Thread Juri Lelli
setup_new_dl_entity() takes two parameters, but it only actually uses one of them, under a different name, to setup a new dl_entity, after: 2f9f3fdc928 "sched/deadline: Remove dl_new from struct sched_dl_entity" as we currently do setup_new_dl_entity(&p->dl, &p->dl) However, before Luca's cha