Re: [PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space

2019-09-04 Thread Leo Yan
Hi Adrian, On Wed, Sep 04, 2019 at 10:26:13AM +0300, Adrian Hunter wrote: [...] > > Could you take chance to review my below replying? I'd like to get > > your confirmation before I send out offical patch. > > It is not necessary to do kallsyms__parse for x86_64, so it would be better > to che

Re: [PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space

2019-09-04 Thread Adrian Hunter
On 2/09/19 5:15 PM, Leo Yan wrote: > Hi Adrian, > > On Mon, Aug 26, 2019 at 08:51:05PM +0800, Leo Yan wrote: >> Hi Adrian, >> >> On Fri, Aug 16, 2019 at 04:00:02PM +0300, Adrian Hunter wrote: >>> On 16/08/19 4:45 AM, Leo Yan wrote: Hi Adrian, On Thu, Aug 15, 2019 at 02:45:57PM +0300

Re: [PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space

2019-09-02 Thread Leo Yan
Hi Adrian, On Mon, Aug 26, 2019 at 08:51:05PM +0800, Leo Yan wrote: > Hi Adrian, > > On Fri, Aug 16, 2019 at 04:00:02PM +0300, Adrian Hunter wrote: > > On 16/08/19 4:45 AM, Leo Yan wrote: > > > Hi Adrian, > > > > > > On Thu, Aug 15, 2019 at 02:45:57PM +0300, Adrian Hunter wrote: > > > > > > [..

Re: [PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space

2019-08-26 Thread Leo Yan
Hi Adrian, On Fri, Aug 16, 2019 at 04:00:02PM +0300, Adrian Hunter wrote: > On 16/08/19 4:45 AM, Leo Yan wrote: > > Hi Adrian, > > > > On Thu, Aug 15, 2019 at 02:45:57PM +0300, Adrian Hunter wrote: > > > > [...] > > > How come you cannot use kallsyms to get the information? > >>> > >>> Tha

Re: [PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space

2019-08-16 Thread Adrian Hunter
On 16/08/19 4:45 AM, Leo Yan wrote: > Hi Adrian, > > On Thu, Aug 15, 2019 at 02:45:57PM +0300, Adrian Hunter wrote: > > [...] > How come you cannot use kallsyms to get the information? >>> >>> Thanks for pointing out this. Sorry I skipped your comment "I don't >>> know how you intend to ca

Re: [PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space

2019-08-15 Thread Leo Yan
Hi Adrian, On Thu, Aug 15, 2019 at 02:45:57PM +0300, Adrian Hunter wrote: [...] > >> How come you cannot use kallsyms to get the information? > > > > Thanks for pointing out this. Sorry I skipped your comment "I don't > > know how you intend to calculate ARM_PRE_START_SIZE" when you reviewed >

Re: [PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space

2019-08-15 Thread Adrian Hunter
On 15/08/19 2:32 PM, Leo Yan wrote: > Hi Adrian, > > On Thu, Aug 15, 2019 at 11:54:54AM +0300, Adrian Hunter wrote: > > [...] > >>> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config >>> index e4988f49ea79..d7ff839d8b20 100644 >>> --- a/tools/perf/Makefile.config >>> +++ b/tool

Re: [PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space

2019-08-15 Thread Leo Yan
Hi Adrian, On Thu, Aug 15, 2019 at 11:54:54AM +0300, Adrian Hunter wrote: [...] > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > > index e4988f49ea79..d7ff839d8b20 100644 > > --- a/tools/perf/Makefile.config > > +++ b/tools/perf/Makefile.config > > @@ -48,9 +48,20 @@ if

Re: [PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space

2019-08-15 Thread Adrian Hunter
On 15/08/19 11:25 AM, Leo Yan wrote: > Arm and arm64 architecture reserve some memory regions prior to the > symbol '_stext' and these memory regions later will be used by device > module and BPF jit. The current code misses to consider these memory > regions thus any address in the regions will b

[PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space

2019-08-15 Thread Leo Yan
Arm and arm64 architecture reserve some memory regions prior to the symbol '_stext' and these memory regions later will be used by device module and BPF jit. The current code misses to consider these memory regions thus any address in the regions will be taken as user space mode, but perf cannot f