Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-20 Thread Masahiro Yamada
On Wed, Jan 20, 2021 at 9:19 AM Will McVicker wrote: > > Hi Masahiro, > > After testing your suggestions for module_srcpath, I remembered why I > needed this: > > +ifneq ($(realpath $(srctree)/$(KBUILD_EXTMOD) 2>/dev/null),) > + module_srcpath := $(srctree)/$(KBUILD_EXTMOD) > +else > +

Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-20 Thread Saravana Kannan
On Wed, Jan 20, 2021 at 6:26 AM Christoph Hellwig wrote: > > On Fri, Jan 08, 2021 at 12:30:35AM +, Will McVicker wrote: > > For example, we have a CI setup that tests new kernel changes on the > > hikey960 and db845c devices without updating their kernel modules. When > > these tests fail, we

Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-20 Thread Christoph Hellwig
On Fri, Jan 08, 2021 at 12:30:35AM +, Will McVicker wrote: > For example, we have a CI setup that tests new kernel changes on the > hikey960 and db845c devices without updating their kernel modules. When > these tests fail, we need to be able to identify the exact device > configuration the tes

Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-19 Thread Will McVicker
Hi Masahiro, After testing your suggestions for module_srcpath, I remembered why I needed this: +ifneq ($(realpath $(srctree)/$(KBUILD_EXTMOD) 2>/dev/null),) + module_srcpath := $(srctree)/$(KBUILD_EXTMOD) +else + module_srcpath := $(KBUILD_EXTMOD) +endif Basically KBUILD_EXTMOD actu

Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-19 Thread Will McVicker
Thanks for the review Masahiro! I'll upload v6 shortly. --Will On Sun, Jan 17, 2021 at 7:21 AM Masahiro Yamada wrote: > > On Fri, Jan 8, 2021 at 9:30 AM Will McVicker wrote: > > > > Config MODULE_SCMVERSION introduces a new module attribute -- > > `scmversion` -- which can be used to identify a

Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-17 Thread Masahiro Yamada
On Fri, Jan 8, 2021 at 9:30 AM Will McVicker wrote: > > Config MODULE_SCMVERSION introduces a new module attribute -- > `scmversion` -- which can be used to identify a given module's SCM > version. This is very useful for developers that update their kernel > independently from their kernel modul

Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-14 Thread Will McVicker
Thanks Jessica for the reviews! --Will On Tue, Jan 12, 2021 at 7:55 AM Jessica Yu wrote: > > +++ Will McVicker [08/01/21 00:30 +]: > >Config MODULE_SCMVERSION introduces a new module attribute -- > >`scmversion` -- which can be used to identify a given module's SCM > >version. This is very

Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-12 Thread Jessica Yu
+++ Will McVicker [08/01/21 00:30 +]: Config MODULE_SCMVERSION introduces a new module attribute -- `scmversion` -- which can be used to identify a given module's SCM version. This is very useful for developers that update their kernel independently from their kernel modules or vice-versa si

[PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-07 Thread Will McVicker
Config MODULE_SCMVERSION introduces a new module attribute -- `scmversion` -- which can be used to identify a given module's SCM version. This is very useful for developers that update their kernel independently from their kernel modules or vice-versa since the SCM version provided by UTS_RELEASE