Re: [PATCH v5] modpost: check for static EXPORT_SYMBOL* functions

2019-08-13 Thread Denis Efremov
On 13.08.2019 19:07, Masahiro Yamada wrote: > Hi Denis, > > I squashed the following fix-up. > > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index 3e6d36ddfcdf..2773f9f9bae2 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -2386,6 +2386,7 @@ static void r

Re: [PATCH v5] modpost: check for static EXPORT_SYMBOL* functions

2019-08-13 Thread Masahiro Yamada
Hi Denis, On Thu, Aug 8, 2019 at 12:12 AM Masahiro Yamada wrote: > > On Thu, Aug 1, 2019 at 3:07 PM Denis Efremov wrote: > > > > This patch adds a check to warn about static EXPORT_SYMBOL* functions > > during the modpost. In most of the cases, a static symbol marked for > > exporting is an odd

Re: [PATCH v5] modpost: check for static EXPORT_SYMBOL* functions

2019-08-07 Thread Masahiro Yamada
On Thu, Aug 1, 2019 at 3:07 PM Denis Efremov wrote: > > This patch adds a check to warn about static EXPORT_SYMBOL* functions > during the modpost. In most of the cases, a static symbol marked for > exporting is an odd combination that should be fixed either by deleting > the exporting mark or by

[PATCH v5] modpost: check for static EXPORT_SYMBOL* functions

2019-07-31 Thread Denis Efremov
This patch adds a check to warn about static EXPORT_SYMBOL* functions during the modpost. In most of the cases, a static symbol marked for exporting is an odd combination that should be fixed either by deleting the exporting mark or by removing the static attribute and adding the appropriate declar